Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BentoML installation documentation and example #2414

Merged
merged 14 commits into from
Apr 7, 2023

Conversation

ssheng
Copy link
Contributor

@ssheng ssheng commented Mar 21, 2023

Description of your changes:

  • Updated the BentoML installation and deployment documentation to include both deployment options, using BentoRequest and Bento CRDs.
  • Updated the BentoML example to align with the example provided from the BentoML GitHub page.
  • Updated Kubeflow manifest README to include installation instructions for BentoML components.

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

@google-cla
Copy link

google-cla bot commented Mar 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliusvonkohout
Copy link
Member

@ssheng you need to sign the CLA

README.md Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Mar 23, 2023
@juliusvonkohout
Copy link
Member

@kimwnasptd should the images be here in the Kubeflow/manifests repository or is the bento repository enough?

@ssheng
Copy link
Contributor Author

ssheng commented Mar 27, 2023

Plese sign CLA

Done. cla/google check is now passing. Please review again.

@ssheng
Copy link
Contributor Author

ssheng commented Mar 28, 2023

@juliusvonkohout Is there anything pending on our side? Please let us know.

@juliusvonkohout
Copy link
Member

/approve

@juliusvonkohout
Copy link
Member

@juliusvonkohout Is there anything pending on our side? Please let us know.

Sadly we have for @kimwnasptd to run the workflows and approve. I am not yet maintainer of the manifests repository.

@jbottum
Copy link

jbottum commented Mar 28, 2023

/lgtm

@jbottum
Copy link

jbottum commented Mar 28, 2023

one note - when I view the file, I see 1.7.0-rc versions of components. should those be 1.7.0, and not RC versions?

@ssheng
Copy link
Contributor Author

ssheng commented Mar 28, 2023

one note - when I view the file, I see 1.7.0-rc versions of components. should those be 1.7.0, and not RC versions?

@jbottum I'm happy to update it to 1.7.0. I put 1.7.0-rc because I saw other components were also referencing 1.7.0-rc. I assume they will be updated together in a separate PR later.

@DomFleischmann
Copy link
Contributor

one note - when I view the file, I see 1.7.0-rc versions of components. should those be 1.7.0, and not RC versions?

@jbottum I'm happy to update it to 1.7.0. I put 1.7.0-rc because I saw other components were also referencing 1.7.0-rc. I assume they will be updated together in a separate PR later.

Yes please update them to 1.7.0

@DomFleischmann
Copy link
Contributor

/lgtm

contrib/bentoml/test.sh Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 3, 2023
@jbottum
Copy link

jbottum commented Apr 4, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 4, 2023
@jbottum
Copy link

jbottum commented Apr 4, 2023

/approve

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 4, 2023

@ssheng after #2432 i can approve

contrib/bentoml/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
example/kustomization.yaml Outdated Show resolved Hide resolved
contrib/bentoml/deployment_from_bento.yaml Show resolved Hide resolved
Co-authored-by: Anna <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 4, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
contrib/bentoml/README.md Show resolved Hide resolved
contrib/bentoml/OWNERS Show resolved Hide resolved
@annajung
Copy link
Member

annajung commented Apr 4, 2023

cc @kimwnasptd looks like github actions are not running and require approval from a maintainer, could you help trigger the workflow?

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbottum, juliusvonkohout, ssheng, yubozhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@annajung
Copy link
Member

annajung commented Apr 4, 2023

I didn't realize that you were not part of the Kubeflow org. Since non members can't be added to the OWNERS file, I suggest removing yourself for now and follow the process to join the Kubeflow org. We can get you added as an owner after you have joined the org.

once the OWNERS file is fixed and the workflow passes, it looks good to me.

Thanks for all your work in updating the bentoML docs for the community.

@ssheng
Copy link
Contributor Author

ssheng commented Apr 4, 2023

I didn't realize that you were not part of the Kubeflow org. Since non members can't be added to the OWNERS file, I suggest removing yourself for now and follow the process to join the Kubeflow org. We can get you added as an owner after you have joined the org.

once the OWNERS file is fixed and the workflow passes, it looks good to me.

Thanks for all your work in updating the bentoML docs for the community.

Thanks for your review, Anna. Just removed myself from the OWNERS file. I will follow the process and join the Kubefow org.

@yubozhao
Copy link

yubozhao commented Apr 7, 2023

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 7, 2023
@google-oss-prow google-oss-prow bot merged commit b1e2982 into kubeflow:master Apr 7, 2023
@ssheng ssheng deleted the bentoml-example branch April 10, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants