-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated BentoML installation documentation and example #2414
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@ssheng you need to sign the CLA |
@kimwnasptd should the images be here in the Kubeflow/manifests repository or is the bento repository enough? |
Done. |
@juliusvonkohout Is there anything pending on our side? Please let us know. |
/approve |
Sadly we have for @kimwnasptd to run the workflows and approve. I am not yet maintainer of the manifests repository. |
/lgtm |
one note - when I view the file, I see 1.7.0-rc versions of components. should those be 1.7.0, and not RC versions? |
@jbottum I'm happy to update it to |
Yes please update them to 1.7.0 |
/lgtm |
/lgtm |
/approve |
Co-authored-by: Anna <[email protected]>
cc @kimwnasptd looks like github actions are not running and require approval from a maintainer, could you help trigger the workflow? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbottum, juliusvonkohout, ssheng, yubozhao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I didn't realize that you were not part of the Kubeflow org. Since non members can't be added to the OWNERS file, I suggest removing yourself for now and follow the process to join the Kubeflow org. We can get you added as an owner after you have joined the org. once the OWNERS file is fixed and the workflow passes, it looks good to me. Thanks for all your work in updating the bentoML docs for the community. |
Thanks for your review, Anna. Just removed myself from the OWNERS file. I will follow the process and join the Kubefow org. |
/lgtm |
Description of your changes:
BentoRequest
andBento
CRDs.Checklist:
Make sure you have installed kustomize == 3.2.1
make generate-changed-only
make test