Promote Julius von Kohout from reviewer to approver for /contrib #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 4, 2023
Merged
|
/lgtm |
|
@elikatsis what do you think? |
|
Thanks for all your work on BentoML, networkpolicies and KubeRay @juliusvonkohout! Looking forward on how to better improve the Kubeflow echosystem and our integrations with external addon/contrib components /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves the current problem that the bentoml update and ray integration is stalled because of lack of approvers. In the future this will also relieve some burden of the manifests maintainers.
Follow up of #2371 and https://github.com/kubeflow/manifests/blob/master/contrib/networkpolicies/OWNERS
@kimwnasptd then we can progress with #2383 and #2414
orthogonal to #2337
Checklist:
Make sure you have installed kustomize == 3.2.1
make generate-changed-onlymake test