Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a swf through kubectl is not reflected in the UI #1363

Closed
strangemonad-faire opened this issue May 21, 2019 · 4 comments
Closed

Deleting a swf through kubectl is not reflected in the UI #1363

strangemonad-faire opened this issue May 21, 2019 · 4 comments
Assignees
@jingzhang36
Labels
area/backend area/frontend kind/feature priority/p1

Comments

@strangemonad-faire
Copy link

I think the underlying source of this bug leads to some other subtle issues.

Ultimately the SWF crd controller and the backend apiserver end up in a split brain scenario.

  • The manual fix is to log into the database and delete the row matching that "job"
  • I'd assume it's possible to make the apiserver smarter and watch for changes to swf crd's and update the job_store accordingly but I feel like all bugs of this nature will be hard to stamp out so long as there are effectively 2 sources of truth (the job_store in apiserver backed by mysql and the custom scheduled workflow resource backed by the state in k8s).
@strangemonad-faire
Copy link
Author

strangemonad-faire commented May 21, 2019 •
edited
Loading

related to #1362

@strangemonad-faire strangemonad-faire mentioned this issue May 21, 2019
Closed
@Bobgy
Copy link
Contributor

Bobgy commented Jan 22, 2020

I think after #1362 is fixed, there's no need to use kubectl to delete swf.

Supported options to delete swf:

  1. use kfp ui
  2. use kfp python client

@Bobgy
Copy link
Contributor

Bobgy commented Jan 22, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@yuzisun
Make kative local gateway configurable (kubeflow#1363)
b63544f 
* Make local gateway configurable

* Fix tests
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@theofpa @yuzisun
support knative 0.19+ (kubeflow#1334)
3b5b1b7 
* replace cluster-local-gateway with knative-local-gateway to support knative 0.19+

* remove istio injection

* update the new variable from kubeflow#1363 to the new local gateway name

* add waiting condition for knative operator

* filter out storage-version-migration-serving-serving from knative condition

* fix json syntax on isvc cm and exclude violations

* replace cluster-local-gateway with knative-local-gateway on v0.5.0

* try removing the local svc url

* Revert "Merge remote-tracking branch 'origin/knative-0.19+' into knative-0.19+"

This reverts commit 1338b34769d7ff6e3b22e6b1ebad15ad4dfa3412, reversing
changes made to 40a4eff11abc325ba840c3397afb8de23de81775.

* replace srv.cluster.local in logger test and increase the number of pytest workers from 3 to 4

Signed-off-by: Theofilos Papapanagiotou <[email protected]>

* update the developer guide for knative 0.19+

Signed-off-by: Theofilos Papapanagiotou <[email protected]>

* revert example image

Signed-off-by: Theofilos Papapanagiotou <[email protected]>

* Change the concurrency back to 3

* Update install/v0.5.0/kfserving.yaml

Co-authored-by: Dan Sun <[email protected]>

* Update install/v0.5.0/kfserving.yaml

Co-authored-by: Dan Sun <[email protected]>

* dev guide detail fix for knative-local-gateway

Signed-off-by: Theofilos Papapanagiotou <[email protected]>

* set pytest concurrency to 4

Signed-off-by: Theofilos Papapanagiotou <[email protected]>

* add namespace on knative-local-gateway

* improve e2e test for logger

* improve e2e test for logger

* rollback changes to 0.5.0 release

Co-authored-by: Dan Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jingzhang36 jingzhang36

Labels
area/backend area/frontend kind/feature priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Bobgy @jingzhang36 @k8s-ci-robot @vicaire @strangemonad-faire