SDK - Refactored _func_to_component_spec to split code generation from signature analysis #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoning777
reviewed
May 20, 2019
gaoning777
reviewed
May 20, 2019
Ark-kun
force-pushed
the
SDK---Refactored-_func_to_component_spec-to-split-out-the-function-signature-analyzer
branch
from
83188ec
to
99cbc7d
Compare
|
/test kubeflow-pipeline-e2e-test |
Ark-kun
force-pushed
the
SDK---Refactored-_func_to_component_spec-to-split-out-the-function-signature-analyzer
branch
from
2d7102a
to
2b0b414
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ark-kun
deleted the
SDK---Refactored-_func_to_component_spec-to-split-out-the-function-signature-analyzer
branch
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* replace cluster-local-gateway with knative-local-gateway to support knative 0.19+ * remove istio injection * update the new variable from kubeflow#1363 to the new local gateway name * add waiting condition for knative operator * filter out storage-version-migration-serving-serving from knative condition * fix json syntax on isvc cm and exclude violations * replace cluster-local-gateway with knative-local-gateway on v0.5.0 * try removing the local svc url * Revert "Merge remote-tracking branch 'origin/knative-0.19+' into knative-0.19+" This reverts commit 1338b34769d7ff6e3b22e6b1ebad15ad4dfa3412, reversing changes made to 40a4eff11abc325ba840c3397afb8de23de81775. * replace srv.cluster.local in logger test and increase the number of pytest workers from 3 to 4 Signed-off-by: Theofilos Papapanagiotou <[email protected]> * update the developer guide for knative 0.19+ Signed-off-by: Theofilos Papapanagiotou <[email protected]> * revert example image Signed-off-by: Theofilos Papapanagiotou <[email protected]> * Change the concurrency back to 3 * Update install/v0.5.0/kfserving.yaml Co-authored-by: Dan Sun <[email protected]> * Update install/v0.5.0/kfserving.yaml Co-authored-by: Dan Sun <[email protected]> * dev guide detail fix for knative-local-gateway Signed-off-by: Theofilos Papapanagiotou <[email protected]> * set pytest concurrency to 4 Signed-off-by: Theofilos Papapanagiotou <[email protected]> * add namespace on knative-local-gateway * improve e2e test for logger * improve e2e test for logger * rollback changes to 0.5.0 release Co-authored-by: Dan Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring is needed to allow using different code generators while sharing the same function signature analysis code.
This change is