Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coverage): add coveralls support #161

Closed
wants to merge 0 commits into from

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Nov 18, 2017

fixes #155


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @jimexist. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jimexist
Copy link
Member Author

@jlewi I think you'll need to enable this repo in coveralls.io (just flip the toggle). After that I can add the badge as well.

@jimexist jimexist changed the title feat(coverage): add covealls support feat(coverage): add coveralls support Nov 18, 2017
@jlewi
Copy link
Contributor

jlewi commented Nov 18, 2017

@jimexist I don't see the repo in coveralls.io; I suspect it might be because I'm not a member of the tensorflow organization.

@jhseu Is coveralls.io something you can enable for this repo?

@jimexist
Copy link
Member Author

@jlewi yes we need someone from tensorflow team to add repo in coverall.io

@jlewi
Copy link
Contributor

jlewi commented Nov 22, 2017

Haven't forgotten about this. I'm guessing Jonathan is out for the holiday. Next week if he hasn't chimed in I'll ping him again and see about getting it enabled.

Thanks for your patience.

@jlewi
Copy link
Contributor

jlewi commented Nov 30, 2017

I pinged @jhseu to see about getting this enabled.

@jimexist
Copy link
Member Author

@jlewi is this enabled yet?

@jlewi
Copy link
Contributor

jlewi commented Dec 18, 2017

@jhseu enabled coveralls.io for the tensorflow.org.

Is there anything else that needs to be done? When I look in coveralls.io I don't see the tensorflow/k8s repository.

@jhseu said that we can only enable coveralls.io in public repo mode;we can't enable it for reading private repos. Do you know what this means?

@jimexist
Copy link
Member Author

jimexist commented Dec 18, 2017

@jlewi i think org owner needs to add org into coveralls.io and also enable the repo for coveralls (i.e. toggle the button)

like this:

screenshot 2017-12-18 22 28 25

@jimexist
Copy link
Member Author

migrated to #232 - sorry that I accidentally closed the branch @jlewi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use coveralls.io to report and check code coverage
3 participants