Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coverage): add covealls support #232

Merged
merged 4 commits into from
Dec 20, 2017
Merged

feat(coverage): add covealls support #232

merged 4 commits into from
Dec 20, 2017

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Dec 18, 2017 •
edited
Loading

This change is Reviewable

fixes #155

@k8s-ci-robot
Copy link

Hi @jimexist. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jimexist jimexist mentioned this pull request Dec 18, 2017
Closed
@jlewi
Copy link
Contributor

jlewi commented Dec 18, 2017

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Dec 19, 2017

@jimexist Looks like travis is broken but maybe it ran before @jhseu enabled coveralls.io so maybe it just needs to be rerun?

@coveralls
Copy link

coveralls commented Dec 19, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling b7a5b9f on Jimexist:local into ** on tensorflow:master**.

@coveralls
Copy link

coveralls commented Dec 19, 2017 •
edited
Loading

Coverage Status

Changes Unknown when pulling fd99fab on Jimexist:local into ** on tensorflow:master**.

@jimexist
Copy link
Member Author

@jlewi @jhseu please review

@jlewi jlewi merged commit 6a2fc9c into kubeflow:master Dec 20, 2017
@jimexist jimexist deleted the local branch December 20, 2017 08:42
@jlewi jlewi mentioned this pull request Dec 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use coveralls.io to report and check code coverage
4 participants
@jimexist @k8s-ci-robot @jlewi @coveralls