Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils net ut #4514

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Utils net ut #4514

merged 2 commits into from
Sep 17, 2024

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Sep 12, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes
  • Tests

image

图中这个函数有问题,ut是无法覆盖的,主要是 /32 ipv4 掩码子网的 first ip 和 last ip 计算结果是错误的。

Which issue(s) this PR fixes

Fixes #(issue-number)

Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
@bobz965
Copy link
Collaborator Author

bobz965 commented Sep 12, 2024

#4494 fix the ipv4 /32 and ipv6 /128

@bobz965 bobz965 marked this pull request as ready for review September 13, 2024 00:58
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 13, 2024
@dosubot dosubot bot added the go Pull requests that update Go code label Sep 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 17, 2024
@oilbeater oilbeater merged commit e2697fc into kubeovn:master Sep 17, 2024
62 checks passed
@bobz965 bobz965 deleted the utils-net-ut branch September 18, 2024 02:18
bobz965 added a commit that referenced this pull request Oct 24, 2024
* add err log

Signed-off-by: bobz965 <[email protected]>

* add ut

Signed-off-by: bobz965 <[email protected]>

---------

Signed-off-by: bobz965 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants