Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOs Installation Adaptations #84

Conversation

ahmedyarub
Copy link
Contributor

Tested :)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2021
@brendandburns
Copy link
Contributor

/lgtm
/approve

We should add a Github action to build on MacOS X and Windows.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedyarub, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit ecc9efc into kubernetes-client:master Sep 20, 2021
@ahmedyarub ahmedyarub deleted the ay/macos_installation_adaptaions branch September 20, 2021 16:04
@ahmedyarub
Copy link
Contributor Author

/lgtm
/approve

We should add a Github action to build on MacOS X and Windows.

I can do that but are you aware of the costs of running these OSes?

@cenit
Copy link

cenit commented Sep 20, 2021

/lgtm
/approve
We should add a Github action to build on MacOS X and Windows.

I can do that but are you aware of the costs of running these OSes?

free for open source projects

@ahmedyarub
Copy link
Contributor Author

I'll be creating another PR with Windows and MacOS pipelines then 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants