Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes] Kubernetes C Client #20255

Merged
merged 17 commits into from
Sep 22, 2021

Conversation

ahmedyarub
Copy link
Contributor

This adds Kubernetes C Client library

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/kubernetes/portfile.cmake

@cenit
Copy link
Contributor

cenit commented Sep 19, 2021

two question:

  1. usage should not be required. Is vcpkg unable to write automatically the same thing as you wrote, inspecting the target the lib creates?
  2. why vcpkg_from_git and not vcpkg_from_github? the latter should be preferred for github repo

@ahmedyarub
Copy link
Contributor Author

This PR fixes the MacOS errors: kubernetes-client/c#84
I'll update this PR once that is merged.

@ahmedyarub
Copy link
Contributor Author

two question:

  1. usage should not be required. Is vcpkg unable to write automatically the same thing as you wrote, inspecting the target the lib creates?
  2. why vcpkg_from_git and not vcpkg_from_github? the latter should be preferred for github repo

Done and done. Thank you.

@ahmedyarub
Copy link
Contributor Author

MacOS version fixed.

@PhoebeHui PhoebeHui self-assigned this Sep 22, 2021
@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 22, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedyarub, thanks for the PR!

ports/kubernetes/vcpkg.json Outdated Show resolved Hide resolved
ports/kubernetes/portfile.cmake Outdated Show resolved Hide resolved
ports/kubernetes/vcpkg.json Show resolved Hide resolved
Ahmed Yarub Hani Al Nuaimi and others added 3 commits September 21, 2021 22:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kubernetes but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 7f48ab7c0aa47748ec9082042a94bdfa39b8367d
-- New SHA: fb0a5c4e7d1497682a26e600e914b50ed7fda57e
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kubernetes but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 7f48ab7c0aa47748ec9082042a94bdfa39b8367d
-- New SHA: 04539a99978e5031d4f83f82c525b3bf6451da0f
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for kubernetes but no changes to version or port version.
-- Version: 0.0.1
-- Old SHA: 7f48ab7c0aa47748ec9082042a94bdfa39b8367d
-- New SHA: d52624c3f3a26d3ad801cca6af68e7bd8273b29b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 22, 2021
@strega-nil-ms
Copy link
Contributor

Cool, Thanks @ahmedyarub !

@strega-nil-ms strega-nil-ms merged commit 48aeaba into microsoft:master Sep 22, 2021
@ahmedyarub ahmedyarub deleted the ay/kubernetes-client branch September 22, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants