Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename deprecatedSecretParamsMap to something else because it also contains non-deprecated fields #224

Closed
gnufied opened this issue Feb 7, 2019 · 5 comments · Fixed by #270
Closed

Rename deprecatedSecretParamsMap to something else because it also contains non-deprecated fields #224

gnufied opened this issue Feb 7, 2019 · 5 comments · Fixed by #270
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@gnufied
Copy link
Contributor

gnufied commented Feb 7, 2019

As subject says, this struct is bit oddly named and appears as if entire struct is deprecated.
@msau42
Copy link
Collaborator

msau42 commented Feb 7, 2019

/kind cleanup
/help

@k8s-ci-robot
Copy link
Contributor

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind cleanup
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 7, 2019
j-griffith added a commit to j-griffith/external-provisioner that referenced this issue Feb 8, 2019
@j-griffith
Rename deprecatedSecretParamsMap
221b87c 
The struct name deprecatedSecretParamsMap is misleading, it includes the
"deprecated" prefix hinting that the struct it deprecated, however it's
not.  It also isn't made up of strictly deprecated secret keys (which
are in fact labeled with the "deprecated" prefix).

Given this a private struct, it's simple to just rename it, this change
renames it to simply "secretParamsMap" and adds a comment to the struct
to give at least a hint as to the intent.

Addresses Bug kubernetes-csi#224
@j-griffith j-griffith mentioned this issue Feb 8, 2019
Closed
@j-griffith
Copy link
Contributor

Giving this back with the help wanted tag for somebody that may want a first easy commit to CSI

j-griffith added a commit to j-griffith/external-provisioner that referenced this issue Feb 9, 2019
@j-griffith
Rename deprecatedSecretParamsMap
1118089 
The struct name deprecatedSecretParamsMap is misleading, it includes the
"deprecated" prefix hinting that the struct it deprecated, however it's
not.  It also isn't made up of strictly deprecated secret keys (which
are in fact labeled with the "deprecated" prefix).

Given this a private struct, it's simple to just rename it, this change
renames it to simply "secretParamsMap" and adds a comment to the struct
to give at least a hint as to the intent.

Addresses Bug kubernetes-csi#224

Revert "Extend allowed DataSources"

This reverts commit b9148ef.
@msau42
Copy link
Collaborator

msau42 commented Apr 13, 2019

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@msau42:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 13, 2019
@hoyho hoyho mentioned this issue Apr 24, 2019
Merged
msau42 added a commit to msau42/external-provisioner that referenced this issue Apr 25, 2023
@msau42
Squashed 'release-tools/' changes from 6613c3980..6e04a0301
bd57d9d 
6e04a0301 Merge pull request kubernetes-csi#224 from msau42/cloudbuild
26fdfffdd Update cloudbuild image

git-subtree-dir: release-tools
git-subtree-split: 6e04a0301338f6e1c05a8e5be1230cf739347c9a
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this issue Dec 29, 2023
@sunnylovestiramisu
Squashed 'release-tools/' changes from 6613c398..4133d1df
2ab3f55 
4133d1df Merge pull request kubernetes-csi#226 from msau42/cloudbuild
8d519d23 Pin buildkit to v0.10.6 to workaround v0.11 bug with docker manifest
6e04a030 Merge pull request kubernetes-csi#224 from msau42/cloudbuild
26fdfffd Update cloudbuild image

git-subtree-dir: release-tools
git-subtree-split: 4133d1df083eaa65bdeddd0530d54278529c7a60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
4 participants
@gnufied @j-griffith @k8s-ci-robot @msau42