Rename deprecatedSecretParamsMap #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR extends the supported DataSources handled by the external-provisioner to include PVCs (Clone) and external API Object types. It removes the restriction of of the provisioner erroring when a DataSource.Kind of anything other than VolumeSnapshot is supplied and adds handling for a DataSource.Kind of PersistentVolumeClaim. In the case of specified DataSources that the provisioner doesn't deal with, we just log that the provisioner doesn't take any action on the specified type, and continue with provisioning ignoring the DataSource field. This not only enables Clone requests, but it also allows development of external controllers to initialize newly created volumes. Additional improvements/enhancements will be added via PV/PVC taints and tolerations when they're implemented. Addresses: Issue kubernetes-csi#172
The struct name deprecatedSecretParamsMap is misleading, it includes the "deprecated" prefix hinting that the struct it deprecated, however it's not. It also isn't made up of strictly deprecated secret keys (which are in fact labeled with the "deprecated" prefix). Given this a private struct, it's simple to just rename it, this change renames it to simply "secretParamsMap" and adds a comment to the struct to give at least a hint as to the intent. Addresses Bug kubernetes-csi#224
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: j-griffith If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
renaming lgtm, but can you remove the commit for the pvc source? |
|
Let's see if somebody new wants to grab this and submit it, otherwise I'll rebase and submit; not like this really hurts anything. |
humblec
added a commit
to humblec/external-provisioner
that referenced
this pull request
Aug 4, 2023
670bb0ef1 Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e783c Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 2b8b80ead fixing some codespell errors 901bcb5a9 Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 670bb0ef135a53be44643cc34440eff22ad3ac8c
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
Skip prow job when on Kubernetes v1.16.
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
de2fba88 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e1 remove windows 20H2 build since it's EOL long time ago 670bb0ef Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e783 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc9 Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76c Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd28211 Update cloudbuild image with go 1.20.5 2b8b80ea fixing some codespell errors 72984ec0 chore: adopt kubernetes recommand label 901bcb5a Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: de2fba88becec7dec6744355a8ddb0057c5fe2f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct name deprecatedSecretParamsMap is misleading, it includes the
"deprecated" prefix hinting that the struct it deprecated, however it's
not. It also isn't made up of strictly deprecated secret keys (which
are in fact labeled with the "deprecated" prefix).
Given this a private struct, it's simple to just rename it, this change
renames it to simply "secretParamsMap" and adds a comment to the struct
to give at least a hint as to the intent.
resolves #224