-
Notifications
You must be signed in to change notification settings - Fork 1.3k
change label seperator from default comma to options #1367
change label seperator from default comma to options #1367
Conversation
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step. If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM, please squash commits before merge |
Jenkins GCE e2e failed for commit b088903. Full PR test history. The magic incantation to run this job again is |
b088903
to
eeb137a
Compare
eeb137a
to
c5ba5c3
Compare
@piosz Done. PTAL. |
Can you add docs? Also I think adding that to metrics will be also useful
in this scenario
…On Thu, 24 Nov 2016 at 0:01 Ning Xie ***@***.***> wrote:
@piosz <https://github.com/piosz> done
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1367 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGCpu39WT7iUeDRxy5D2uCzXJlGT3UBks5rBLeigaJpZM4Kqesu>
.
|
+1 to #1367 (comment) |
c5ba5c3
to
b853f10
Compare
b853f10
to
bdfa6cc
Compare
@AlmogBaku @piosz Doc about |
@k8s-bot ok to test |
Thanks @andyxning. I'll merge once I'll be able to make tests green. |
Currently, we use hard code comma as the label seperator for concatnating key-value labels. The label string is like:
This is fine until we use Bosun as the alert system and use the
group by labels
to search for labels.As currently, bosun use comma to split queried tag key and tag value. For example if the query expression used for query InfluxDB from Bosun is something like this:
Then, we will get tagkey and tag value string like this:
When split by a comma, something wrong happened. we split it wrongly to this:
the last two tag key-value pairs is wrong. This will make bosun confused and panic with something like "panic: opentsdb: bad tag: beta.kubernetes.io/os:linux".
This PR will add a new command line
--label-seperator
for heapster. And, in order to keep backward compatibility, the default value for--label-seperator
is comma. We can specify semicolon as the seperator to walk around the bosun restrictionThis change is