-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add gofmt to makefile #1368
add gofmt to makefile #1368
Conversation
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step. If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository. |
Hey, On Sun, Nov 6, 2016 at 1:46 PM, Ning Xie [email protected] wrote:
www.rimoto.com http://www.rimoto.net/ Almog Baku CTO & Cofounder * |
@AlmogBaku yes one of my pr is reported failed with gofmt error. After gofmt them, everthing is good. 😂 |
see the first and the second commit in #1367 to learn more info about this. |
@k8s-bot ok to test |
LGTM, will merge on green |
@andyxning: you can't request testing unless you are a kubernetes member. In response to this comment:
If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository. |
@piosz Can you please take a look at the Jenkins GCE e2e test fail message. I have no idea about how to fix it. |
Bumped cluster version in #1394. Let's see whether it will help |
@k8s-bot test this |
@kubernetes/test-infra-maintainers e2e tests are failing due to some infra problems. Could you please take a look? |
@piosz it looks more like a broken test than broken infra to me, but I'm not familiar with the heapster integration test. |
@k8s-bot test this |
@k8s-bot test this |
@ixdy is test bot working correctly? |
@piosz Jenkins got pretty DOS'd with the code freeze unthawing. We're restarting it now. |
@ixdy thanks for the info! |
@k8s-bot test this |
@andyxning could you please rebase the PR? |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
65aafd7
to
06c1aa1
Compare
Jenkins GCE e2e failed for commit 06c1aa1. Full PR test history. The magic incantation to run this job again is |
06c1aa1
to
6881c24
Compare
CLAs look good, thanks! |
@piosz Done. |
@andyxning thanks! |
This PR add gofmt to Makefile.
make fmt
to gofmt the codefmt
will be run automatically whenmake build
This change is