add gofmt to makefile

[andyxning]

This PR add gofmt to Makefile.

fmt:
	find . -type f -name "*.go" | grep -v "./vendor*" | xargs gofmt -s -w

build: clean deps fmt
	GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -o heapster k8s.io/heapster/metrics
	GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -o eventer k8s.io/heapster/events

• run make fmt to gofmt the code
• fmt will be run automatically when make build

---

This change is

[k8s-ci-robot]

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

[andyxning]

@piosz @AlmogBaku @huangyuqi

[AlmogBaku]

Hey,
That's looks okay, however I'm not sure why is that required? anyway PRs
fails in case the code isn't gofmtted..

On Sun, Nov 6, 2016 at 1:46 PM, Ning Xie [email protected] wrote:

@piosz https://github.com/piosz @AlmogBaku
https://github.com/AlmogBaku

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1368 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGCpqWCRKACloufHu2cTbhpitXrcTbpks5q7b4zgaJpZM4KqfIQ
.

http://www.rimoto.net/

www.rimoto.com http://www.rimoto.net/

Almog Baku

CTO & Cofounder *
Mobile: +972.50.2288.744
Social: * http://www.facebook.com/AlmogBaku
http://www.linkedin.com/in/almogbaku

[andyxning]

@AlmogBaku yes one of my pr is reported failed with gofmt error. After gofmt them, everthing is good. 😂

[andyxning]

see the first and the second commit in #1367 to learn more info about this.

[piosz]

@k8s-bot ok to test

[piosz]

LGTM, will merge on green

[k8s-ci-robot]

@andyxning: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot test this

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

[andyxning]

@piosz Can you please take a look at the Jenkins GCE e2e test fail message. I have no idea about how to fix it.

[piosz]

Bumped cluster version in #1394. Let's see whether it will help

[piosz]

@k8s-bot test this

[piosz]

@kubernetes/test-infra-maintainers e2e tests are failing due to some infra problems. Could you please take a look?

[ixdy]

@piosz it looks more like a broken test than broken infra to me, but I'm not familiar with the heapster integration test.

[piosz]

@k8s-bot test this

[piosz]

@ixdy thanks. It's weird, because I updated Kubernetes version in #1394 and the method was invoked with
godep go test -v --timeout=60m ./integration/... --vmodule=*=2 --namespace=heapster-e2e-tests --kube_versions="1.3.6"

[piosz]

@k8s-bot test this

[piosz]

@ixdy is test bot working correctly?

[ixdy]

@piosz Jenkins got pretty DOS'd with the code freeze unthawing. We're restarting it now.

[piosz]

@ixdy thanks for the info!

[ixdy]

@k8s-bot test this

[andyxning]

@piosz Maybe this PR can be merged with no worries. The Travis CI failure is about OOM which should be addressed by merging #1364 .

[piosz]

@andyxning could you please rebase the PR?

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

[k8s-ci-robot]

Jenkins GCE e2e failed for commit 06c1aa1. Full PR test history.

The magic incantation to run this job again is @k8s-bot test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

[googlebot]

CLAs look good, thanks!

[andyxning]

@piosz Done.

[piosz]

@andyxning thanks!