build: rewrite dockerfile to distroless #1098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
huww98
force-pushed
the
rewrite-dockerfile
branch
2 times, most recently
from
5f79f77
to
e801884
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
huww98
force-pushed
the
rewrite-dockerfile
branch
3 times, most recently
from
d1c475d
to
d25c1be
Compare
|
We still have some more deps to be eliminated:
|
huww98
force-pushed
the
rewrite-dockerfile
branch
from
d25c1be
to
2eaf83a
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
huww98
force-pushed
the
rewrite-dockerfile
branch
from
2eaf83a
to
a013f99
Compare
|
should rebase after #1102 got merged. And remove |
k8s-ci-robot
added
the
needs-rebase
huww98
force-pushed
the
rewrite-dockerfile
branch
from
a013f99
to
3f5cf42
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
huww98
force-pushed
the
rewrite-dockerfile
branch
from
3f5cf42
to
0f77dd4
Compare
k8s-ci-robot
added
needs-rebase
With the help of shellcheck
Only copy necessary binaries. Cross compile util-linux. init container is switched to busybox. Note that the partition expansion is known broken. growpart is a shell script, but we don't include shell now.
huww98
force-pushed
the
rewrite-dockerfile
branch
from
0f77dd4
to
bd5c158
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Only copy necessary binaries.
Cross compile util-linux.
init container is switched to busybox.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
amd64+arm64 only 144MiB
Note that the partition expansion is known broken. growpart is a shell script, but we don't include shell now.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: