Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk: remove the call to NeedResize #1102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Jul 1, 2024

What type of PR is this?

What this PR does / why we need it:

It is unnecessary, the Resize itself is idempotent. Get rid of the dependency on blockdev executable.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2024
@mowangdk
Copy link
Contributor

This is refer to the aws ebs driver .

@huww98
Copy link
Contributor Author

huww98 commented Jul 17, 2024

That does not mean it is good.

It is unnecessary, the Resize itself is idempotent.
Get rid of the dependency on blockdev executable.
@huww98
Copy link
Contributor Author

huww98 commented Jul 17, 2024

rebased to resolve conflict

@mowangdk
Copy link
Contributor

There might be a reason behind it, let's proceed straightforwardly.

@huww98
Copy link
Contributor Author

huww98 commented Jul 18, 2024

https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/27ac6ca1261e71082f1d2e982d345cdf9b06b58b/pkg/gce-pd-csi-driver/node.go#L381 Google does not check.

We also not checking at other place.

ok, err := r.Resize(devicePath, volumePath)

So, not checking should be more straightforward.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants