-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chart repo index.yaml to contain all currently available chart versions #623
Conversation
Signed-off-by: krmichel <[email protected]>
Hi @krmichel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This also supersedes PR #620 |
@leakingtapan This PR should temporarily fix the index.yaml in the chart repository being out of date. I will create another PR shortly to deal with it in an automated fashion, but this PR will need merged first by at least enough time for the github pages page to update. |
PR #624 Should deal with the index.yaml moving forward, but shouldn't be merged until after this PR is merged and the new index.yaml is showing up in the repo. |
/approve Just one commnet about the kubeVersion field |
@wongma7 I replied to your comment about the kube version. If we can get this merged I will fix it in my other PR. If I fix it before this gets merged then my index.yaml for this PR will get updated to have 0.6.2 pointing at the wrong release (it would be the one from my fork) |
hmmm OK, merging this then! /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: krmichel, wongma7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wongma7 I am not sure why but your approve doesn't seem to have added the label that the bot wants |
I think it's because there is no OWNERS file in this branch, no worries, I can manually merge. |
Is this a bug fix or adding new feature?
This is a temporary bug fix to get all of the available chart versions into the chart repository
What is this PR about? / Why do we need it?
Currently the index.yaml for the chart repo is being maintained by hand and is out of date. This will update the index to contain all currently available chart versions.
What testing is done?
I have tested the index.yaml from my own chart repository.
I will create another PR to automatically manage the chart repository on pushes when it is updated. This PR needs merged first so when the other change is made it has a correct index.yaml to merge updates into.
fixes #557
fixes #587
fixes #617