Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chart to charts directory and add workflow to publish new chart versions #624

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

krmichel
Copy link
Contributor

Is this a bug fix or adding new feature?
This is a feature
What is this PR about? / Why do we need it?
Currently managing the index.yaml of the helm chart repository is a manual process and gets out of date quickly. This will move the chart to be a sub-directory of charts which is a pretty standard structure. It also adds a workflow action that will publish a release of the chart and update the index.yaml in the chart repo. The workflow action will also fail if the chart is updated and merged to master without the version being updated (the version of the chart should be increased whenever the chart is modified).
What testing is done?
I tried out the workflow action in my own repo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @krmichel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 27, 2020
@krmichel
Copy link
Contributor Author

@leakingtapan This should not be merged until after PR #623 has been merged and the index.yaml is showing as updated in the chart repository at https://kubernetes-sigs.github.io/aws-ebs-csi-driver/index.yaml to show all the available versions or the workflow action won't have the correct version of the index to merge the new version into.

@krmichel krmichel mentioned this pull request Nov 27, 2020
@krmichel
Copy link
Contributor Author

This should prevent issues like #557 #587 #617 in the future

@krmichel krmichel mentioned this pull request Nov 27, 2020
@coveralls
Copy link

coveralls commented Nov 27, 2020

Pull Request Test Coverage Report for Build 1334

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.253%

Totals Coverage Status
Change from base Build 1331: 0.0%
Covered Lines: 1595
Relevant Lines: 1963

💛 - Coveralls

@krmichel
Copy link
Contributor Author

@jsafrane @d-nishi @leakingtapan Can I get an okay to test?

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2020
@krmichel
Copy link
Contributor Author

/retest

@krmichel
Copy link
Contributor Author

@jsafrane @d-nishi @leakingtapan Tests have all passed when you get a chance to look at this. Please look at PR #623 first though.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2020
@krmichel
Copy link
Contributor Author

krmichel commented Dec 3, 2020

@wongma7 Here is the PR I mentioned earlier so you can verify the kube version change

git config user.name "$GITHUB_ACTOR"
git config user.email "[email protected]"
- name: Run chart-releaser
uses: helm/[email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/README.md Show resolved Hide resolved
@wongma7
Copy link
Contributor

wongma7 commented Dec 4, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2020
@wongma7
Copy link
Contributor

wongma7 commented Dec 4, 2020

Sorry do you mind rebasing I merged a months old small pr fixing some naming issues. thanks

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 5, 2020
@krmichel
Copy link
Contributor Author

krmichel commented Dec 5, 2020

@wongma7 I have resolved the conflict

@wongma7
Copy link
Contributor

wongma7 commented Dec 7, 2020

/lgtm
/approve

thank you very much for all your contributions to the helm chart!!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krmichel, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b44b5bc into kubernetes-sigs:master Dec 7, 2020
@krmichel
Copy link
Contributor Author

krmichel commented Dec 7, 2020

@wongma7 it looks like the gh-pages branch is protected and declined the index.yaml update from the action.
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/runs/1513656332
It look like I might be able to have it create PRs, but I think it would be better if it could be setup to allow the publish without a PR so there aren't move of the chart repo is out of date issues. Thoughts?

@wongma7
Copy link
Contributor

wongma7 commented Dec 7, 2020

let me check if I can turn off branch protection. https://github.com/kubernetes/test-infra/blob/2abb7ff26579325f6a335990003f665755c96d7a/prow/cmd/branchprotector/README.md#advanced-configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants