Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add ref grant #101

Closed
wants to merge 2 commits into from
Closed

Conversation

tanujd11
Copy link

Fixes #14

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

Signed-off-by: tanujd11 <[email protected]>
@shaneutt
Copy link
Member

Thank you so much for your contribution @tanujd11!

I wanted to check in with you real quick, because I'm not sure if you're aware but this project is being donated to the CNCF, all the details of which can be seen here:

#42

Note: The process has been really slow because of our use of the GPLv2 license, details about that are
available in cncf/foundation#474

During this interim time we ask that all contributors sign the CNCF CLA as well, so that there will be no further hangups when it comes time to migrate. Instructions on how to do this are in that discussion, if you need any assistance or have any problems with this please let us know!

@shaneutt
Copy link
Member

Looks like the tests aren't happy with the change (they rely on sample manifests). Also I noticed that no new tests for ReferenceGrant were supplied yet, we'll want to add at least some basic integration tests for this. Let us know if you're up for that, and if you have any trouble with the integration test suite or anything let us know and we'll be happy to help!

@shaneutt
Copy link
Member

hey! 👋

Just checking in. Everything going ok? Getting stuck, need help?

@tanujd11
Copy link
Author

Hey @shaneutt I did not get time to get around this. Will take a look at this over the weekend.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shaneutt shaneutt marked this pull request as draft October 20, 2023 11:59
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@shaneutt
Copy link
Member

Since we haven't heard back from you in a while on this one, we're going to close this for now. This is just to manage our inventory of issues and PRs, but if you find you have time again please feel free to re-open and let us know how we can support your efforts!

@shaneutt shaneutt closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controlplane area/gateway-api do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. feature New feature or request needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
Development

Successfully merging this pull request may close these issues.

ReferenceGrant Support
4 participants