Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update k8s API to v1.25 #7123

Closed
wants to merge 5 commits into from
Closed

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Aug 25, 2022

This PR bumps required k8s libraries and fixes breaking changes introduced there.

Signed-off-by: Mikhail Fedosin [email protected]

Part of #6661

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval by writing /assign @cecilerobertmichon in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Fedosin! We should wait for an update to the versions used by controller runtime before we bump Kubernetes in Cluster API.

Part of #6661

@killianmuldoon
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2022
@Fedosin Fedosin changed the title Update k8s API to v1.25 🌱 Update k8s API to v1.25 Aug 25, 2022
@Fedosin Fedosin changed the title 🌱 Update k8s API to v1.25 🌱 Update k8s API to v1.25 Aug 25, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2022
Kubernetes v1.25 has been released, so we can update our dependencies.
All log config methods became functions in v1.25:
kubernetes/component-base@41262c3
@sbueringer
Copy link
Member

Thanks for the contribution @Fedosin! We should wait for an update to the versions used by controller runtime before we bump Kubernetes in Cluster API.

Part of #6661

+1
There doesn't seem to be a PR yet to bump CR to the final v1.25.0 rc release so if someone wants to open that PR there... :)

cc @oscr (just that you're aware this PR exists)

generate by `make generate`
@sbueringer
Copy link
Member

sbueringer commented Aug 25, 2022

Thx for the bump in CR!

I would suggest to bump to the latest commit on CR main. I know it's not a release but we still have a lot of time until the CAPI release. So this should give us enough time to pick up a CR release once it exists (and I would add a sub-task to #6661 for it)

@vincepri WDYT?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 25, 2022

@Fedosin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 726955b link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

Agree with @sbueringer, we follow and bundle what Controller Runtime offers, the version should be updated there first and picked up in the next release

@sbueringer
Copy link
Member

@Fedosin To clarify. We want to wait for the next CR release v0.13.0 to have a released version of CR with the right dependencies. CR is probably released relatively soon

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2022
@k8s-ci-robot
Copy link
Contributor

@Fedosin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

sbueringer commented Sep 2, 2022

@Fedosin When you've got some time, can you please pick up controller-runtime v0.13 as well? Thank you!

@sbueringer
Copy link
Member

@Fedosin When you've got some time, can you please pick up controller-runtime v0.13 as well? Thank you!

@Fedosin Do you have time to address this?

@sbueringer
Copy link
Member

Thx for your work on this issue. We'll continue the work in a follow-up PR in a bit.

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

Thx for your work on this issue. We'll continue the work in a follow-up PR in a bit.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants