-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update k8s API to v1.25 #7123
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold |
Kubernetes v1.25 has been released, so we can update our dependencies.
All log config methods became functions in v1.25: kubernetes/component-base@41262c3
+1 cc @oscr (just that you're aware this PR exists) |
generate by `make generate`
@Fedosin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Agree with @sbueringer, we follow and bundle what Controller Runtime offers, the version should be updated there first and picked up in the next release |
@Fedosin To clarify. We want to wait for the next CR release v0.13.0 to have a released version of CR with the right dependencies. CR is probably released relatively soon |
@Fedosin: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Fedosin When you've got some time, can you please pick up controller-runtime v0.13 as well? Thank you! |
Thx for your work on this issue. We'll continue the work in a follow-up PR in a bit. /close |
@sbueringer: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR bumps required k8s libraries and fixes breaking changes introduced there.
Signed-off-by: Mikhail Fedosin [email protected]
Part of #6661