Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump controller-runtime to use new Kubernetes Go libraries #7211

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Sep 12, 2022

What this PR does / why we need it:

Building upon the work of #7123 this pr also bumps controller-runtime and fixes the breaking changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6661

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 12, 2022
Co-authored-by: Mike Fedosin <[email protected]>
Co-authored-by: Oscar Utbult <[email protected]>
@sbueringer
Copy link
Member

/test ?

@k8s-ci-robot

This comment was marked as resolved.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

@sbueringer
Copy link
Member

/lgtm

Waiting with approve until the tests are green

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 12, 2022

@oscr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 9e55898 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

I don't really think this is related to the changes in this PR

@sbueringer
Copy link
Member

Okay good enough :)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit eb5ae53 into kubernetes-sigs:main Sep 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 12, 2022
@oscr oscr deleted the k8s_v125 branch September 12, 2022 16:39
@sbueringer sbueringer mentioned this pull request Sep 12, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants