-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump controller-runtime to use new Kubernetes Go libraries #7211
Conversation
...netes-sig/cluster-api/test/infrastructure/docker/exp/api/v1alpha3/zz_generated.conversion.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Fedosin <[email protected]> Co-authored-by: Oscar Utbult <[email protected]>
/test ? |
This comment was marked as resolved.
This comment was marked as resolved.
/test pull-cluster-api-e2e-full-main |
/lgtm Waiting with approve until the tests are green |
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main |
@oscr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main I don't really think this is related to the changes in this PR |
Okay good enough :) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Building upon the work of #7123 this pr also bumps controller-runtime and fixes the breaking changes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #6661