Add a helm chart

[krmichel]

Fixes #103

Before this is merged there will need to be a gh-pages branch created (probably with nothing but a .gitignore file in it) to house the chart repo's index.yaml. If you need any help let me know and I can provide some git commands to help with that. In the event that the gh-pages branch is protected here is a PR in another kubernetes-sigs repo that needed to be changed with a reference to a change in test-infra

kubernetes-sigs/aws-ebs-csi-driver#624

[k8s-ci-robot]

Welcome @krmichel!

It looks like this is your first PR to kubernetes-sigs/cluster-proportional-autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-proportional-autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[krmichel]

@MrHohn Here is the PR for the helm chart as promised

[MrHohn]

Thanks @krmichel! I'm not particularly familiar with the helm chart templating, but tried to go over the configuration and RBAC etc. and they looks sane to me.

I have a comment regarding the multi-arch image and will LGTM after that.

/approve

[MrHohn]

Before this is merged there will need to be a gh-pages branch created (probably with nothing but a .gitignore file in it) to house the chart repo's index.yaml.

I can create that once this PR is merged.

[krmichel]

I can create that once this PR is merged.

You can wait until after the merge. If you do the action to release the chart will fail right after the merge. However, I think you can then create the branch and go into the actions and tell it to rerun them.

[krmichel]

@MrHohn, sorry I think I just accidentally cleared your approval.

[MrHohn]

Thanks for your work @krmichel!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krmichel, MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MrHohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MrHohn]

@krmichel gh-pages branch is created on https://github.com/kubernetes-sigs/cluster-proportional-autoscaler/tree/gh-pages.

[MrHohn]

The "Release Helm Charts" job failed initially as you mentioned. I manually rerun it and it is all good now. Let me know if you see any more issue.

[krmichel]

@MrHohn I forgot that because the github release was already created the workflow doesn't think it needs to do anything for the chart version. I think the options are either we delete the release and the tag so the actions sees that it needs to run or I (or someone) make a PR bumping the chart version to 1.0.1 and merge it to make sure it creates the needed file in the gh-pages branch.

[VioletCranberry]

Hello guys!

Sorry for bothering, but is there any update on this workflow?
The index.yaml is missing indeed, so any repo add fails as of now:

helm repo add cluster-proportional-autoscaler https://kubernetes-sigs.github.io/cluster-proportional-autoscaler
Error: looks like "https://kubernetes-sigs.github.io/cluster-proportional-autoscaler" is not a valid chart repository or cannot be reached: 
failed to fetch https://kubernetes-sigs.github.io/cluster-proportional-autoscaler/index.yaml : 404 Not Found

Thanks in advance! :)

[MrHohn]

So I went for the first approach and hit another issue:

HEAD is now at a482144 Merge pull request #113 from krmichel/master
[detached HEAD f543c53] Update index.yaml
 1 file changed, 18 insertions(+)
 create mode 100644 index.yaml
Pushing to branch "gh-pages"
remote: error: GH006: Protected branch update failed for refs/heads/gh-pages.        
remote: error: Required status check "cla/linuxfoundation" is expected.        
To https://github.com/kubernetes-sigs/cluster-proportional-autoscaler
 ! [remote rejected] HEAD -> gh-pages (protected branch hook declined)
error: failed to push some refs to 'https://github.com/kubernetes-sigs/cluster-proportional-autoscaler'
Error: exit status 1

Looks like we might need something similar to kubernetes-sigs/aws-ebs-csi-driver#624 as you mentioned.

[krmichel]

@MrHohn This PR has been merged do you want to delete the release and tag and try again?
kubernetes/test-infra#22996

[MrHohn]

@krmichel Thanks for that - I didn't know that config lives in prow :)

Re-run the job and it completes successfully this time.

[krmichel]

@VioletCranberry I think it is working now