Add Additional Details To Pod Eviction Log Messages #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
seanmalloy
commented
May 12, 2020
seanmalloy
commented
- 3a204de - all strategies log error from EvictPod method
- 55de441 - add pod namespace to pod eviction log messages
k8s-ci-robot
added
cncf-cla: yes
|
Looks like the Travis CI tests did not get triggered :-( |
|
Close and re-open to try and make Travis CI work. |
damemi
reviewed
May 12, 2020
k8s-ci-robot
added
the
needs-rebase
ingvagabund
reviewed
May 13, 2020
In multi-tenant environments it is useful to know which namespace a pod was evicted from. Therefore log the namespace when evicting pods. Also, do not log a nil error when successfully evicting pods.
End users should be able to see the detailed error from the EvictPod method when it fails. Updates all strategies to log the error. The PodLifeTime strategy already logs this error.
The EvictPod function previously returned a bool and an error. The function now only returns an error. Callers can check for failure by testing if the returned error is not nil. This aligns the EvictPod function with idiomatic Go best practices. Also, the function name has been changed from EvictPod to evictPod because it is not used outside the evictions package.
k8s-ci-robot
added
size/M
|
@damemi and @ingvagabund PTAL when you have some time. I believe I addressed all of your feedback. |
|
@seanmalloy thanks for addressing all the comments |
k8s-ci-robot
added
the
lgtm
damemi
approved these changes
May 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damemi, seanmalloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
4 tasks
briend
pushed a commit
to briend/descheduler
that referenced
this pull request
Feb 11, 2022
…logs Add Additional Details To Pod Eviction Log Messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.