Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Additional Details To Pod Eviction Log Messages #279

Merged
merged 4 commits into from
May 14, 2020
Merged

Add Additional Details To Pod Eviction Log Messages #279

merged 4 commits into from
May 14, 2020
+36 −25

Commits on May 14, 2020

  1. Add namespace to pod eviction log messages 

    In multi-tenant environments it is useful to know which namespace a pod
was evicted from. Therefore log the namespace when evicting pods.

Also, do not log a nil error when successfully evicting pods.
    @seanmalloy
    seanmalloy committed May 14, 2020
    Configuration menu
    Copy the full SHA
    4819ab9 View commit details
    Browse the repository at this point in the history

  2. Log an error when EvictPod method returns a non-nil error 

    End users should be able to see the detailed error from the EvictPod
method when it fails. Updates all strategies to log the error. The
PodLifeTime strategy already logs this error.
    @seanmalloy
    seanmalloy committed May 14, 2020
    Configuration menu
    Copy the full SHA
    cff9842 View commit details
    Browse the repository at this point in the history

  3. Refactor function EvictPod to only return an error 

    The EvictPod function previously returned a bool and an error. The
function now only returns an error. Callers can check for failure by
testing if the returned error is not nil. This aligns the EvictPod
function with idiomatic Go best practices.

Also, the function name has been changed from EvictPod to evictPod
because it is not used outside the evictions package.
    @seanmalloy
    seanmalloy committed May 14, 2020
    Configuration menu
    Copy the full SHA
    7039b6c View commit details
    Browse the repository at this point in the history

  4. Remove line break in log message from PodLifeTime strategy

    @seanmalloy
    seanmalloy committed May 14, 2020
    Configuration menu
    Copy the full SHA
    55afde6 View commit details
    Browse the repository at this point in the history