Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway.Spec.Listener[x].Routes.Selector should be a pointer #571

Closed
stevesloka opened this issue Mar 3, 2021 · 1 comment · Fixed by #572
Closed

Gateway.Spec.Listener[x].Routes.Selector should be a pointer #571

stevesloka opened this issue Mar 3, 2021 · 1 comment · Fixed by #572
Assignees
@stevesloka
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@stevesloka
Copy link
Contributor

stevesloka commented Mar 3, 2021 •
edited
Loading

What happened:

When implementing GatewayAPI, I noticed the selector field on a Gateway.Spec.Listener[x].Routes.Selector (https://gateway-api.sigs.k8s.io/spec/#networking.x-k8s.io/v1alpha1.RouteBindingSelector) is currently not a pointer, but nice if it was to know if the field has been provided or not by a user.

I’m using the LabelSelectorAsSelector method from api-machinery to then use labels.Matches(…), but LabelsSelectorAsSelector takes a pointer to the Selector.

//cc @danehans
@stevesloka stevesloka added the kind/bug Categorizes issue or PR as related to a bug. label Mar 3, 2021
@stevesloka
Copy link
Contributor Author

/assign

stevesloka pushed a commit to stevesloka/service-apis that referenced this issue Mar 3, 2021
@stevesloka
api: Update Gateway.Spec.Listener[x].Routes.Selector to be a pointer
8d748b6 
Fixes kubernetes-sigs#571

Signed-off-by: Steve Sloka <[email protected]>
@stevesloka stevesloka mentioned this issue Mar 3, 2021
Merged
stevesloka added a commit to stevesloka/service-apis that referenced this issue Mar 3, 2021
@stevesloka
api: Update Gateway.Spec.Listener[x].Routes.Selector to be a pointer
837108d 
Fixes kubernetes-sigs#571

Signed-off-by: Steve Sloka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevesloka stevesloka

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: Update Gateway.Spec.Listener[x].Routes.Selector to be a pointer stevesloka/service-apis
1 participant
@stevesloka