-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add auditor e2e test for promoting an image to a subproject prefix #201
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: listx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unassign @tpepper @bartsmykla |
/uncc @tpepper @bartsmykla |
@listx: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cool, I can see
in the logs for this invocation, so indeed I can reproduce the error described in #191 with this test case. I think this pretty much nails it --- #199 and #200 are ready for merging...! @justinsb @bartsmykla |
Closing this PR as the bug reproduction has been demonstrated. |
@listx: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold
With #200 passing e2e tests, I am pushing this one up (without the fixes, but with the new e2e test) to see if I can reproduce what I've been seeing in production. Because why not?