Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add auditor e2e test for promoting an image to a subproject prefix #201

Closed
wants to merge 1 commit into from

Conversation

listx
Copy link
Contributor

@listx listx commented Mar 14, 2020

/hold

With #200 passing e2e tests, I am pushing this one up (without the fixes, but with the new e2e test) to see if I can reproduce what I've been seeing in production. Because why not?

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: listx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 14, 2020
@listx
Copy link
Contributor Author

listx commented Mar 14, 2020

/unassign @tpepper @bartsmykla

@listx
Copy link
Contributor Author

listx commented Mar 14, 2020

/uncc @tpepper @bartsmykla

@k8s-ci-robot
Copy link
Contributor

@listx: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cip-auditor-e2e 1f18282 link /test pull-cip-auditor-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@listx
Copy link
Contributor Author

listx commented Mar 14, 2020

Cool, I can see

(db4a9afe-cc8c-453a-8f99-0b8c0f0ec42c) TRANSACTION REJECTED: could not determine source registry: &{INSERT us.gcr.io/k8s-gcr-audit-test-prod/subproject-foo/foo@sha256:2af5205553239e0eb17c544bc1e90c2d6173012a191f0a44131aa2f9c44bb511 }

in the logs for this invocation, so indeed I can reproduce the error described in #191 with this test case. I think this pretty much nails it --- #199 and #200 are ready for merging...! @justinsb @bartsmykla

@listx
Copy link
Contributor Author

listx commented Mar 14, 2020

Closing this PR as the bug reproduction has been demonstrated.
/close

@k8s-ci-robot
Copy link
Contributor

@listx: Closed this PR.

In response to this:

Closing this PR as the bug reproduction has been demonstrated.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@listx listx deleted the reproduce-auditor-error branch May 8, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants