Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add project-name config key and optional init --project-name #1603

Merged

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Jul 22, 2020

This PR adds a project-name config key and an optional init --project-name to the v3-alpha plugin. Plugin authors for non-Go plugins will find such a key useful, as repo doesn't make much sense for non-Go plugins. This reverts #1596 behavior.

Changes:

  • pkg/model/config: add 'project-name' which configures a project's name
  • pkg/plugin/v3/init.go: add --project-name which sets a config's 'project-name' key

/cc @pwittrock @camilamacedo86

pkg/plugin/v3/init.go: add --project-name which sets a config's 'project-name' key
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2020
@estroz
Copy link
Contributor Author

estroz commented Jul 22, 2020

Holding for discussion

/hold

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 22, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
For you are able to merge when you wish.
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@pwittrock
Copy link
Contributor

Thanks!

@pwittrock
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@pwittrock
Copy link
Contributor

LGTM

@k8s-ci-robot k8s-ci-robot merged commit 851e4f5 into kubernetes-sigs:master Jul 23, 2020
@estroz estroz deleted the feature/project-name-config branch July 23, 2020 16:22
@@ -41,6 +41,9 @@ type Config struct {
// Repo is the go package name of the project root
Repo string `json:"repo,omitempty"`

// ProjectName is the name of this controller project set on initialization.
ProjectName string `json:"project-name,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit here:

Since Kubernetes YAMLs usually use camelCase, should we make this projectName?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably :) @estroz want to follow up with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants