🌱 config-gen: command docs no longer depend on local environment #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/cc @pwittrock |
k8s-ci-robot
added
the
approved
|
Not sure why coverage is falling by so much. |
2 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: estroz, pwittrock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
estroz
force-pushed
the
docs/config-gen-static-cmd-docs
branch
from
c123292
to
ea29c0b
Compare
k8s-ci-robot
removed
the
lgtm
|
Making sure perms work /hold |
k8s-ci-robot
added
the
do-not-merge/hold
estroz
force-pushed
the
docs/config-gen-static-cmd-docs
branch
from
ea29c0b
to
aca589e
Compare
estroz
commented
Mar 18, 2021
estroz
force-pushed
the
docs/config-gen-static-cmd-docs
branch
from
aca589e
to
f7b0ae3
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm +1 I like the checking more. |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating CLI docs using cobra's docs generator,
this doc is generated inconsistently depending on what
environment the command is run. This PR fixes that
problem by using a static path and saying where the
dynamic part comes from.