Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable 'alpha config-gen' command #4670

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

estroz
Copy link
Member

@estroz estroz commented Mar 17, 2021

Description of the change:

  • internal/cmd/operator-sdk/cli: un-hide alpha config-gen

Motivation for the change: users should be able to use and give feedback on alpha commands. See #4667 (comment) for discussion.

/kind feature

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 17, 2021
@estroz estroz mentioned this pull request Mar 17, 2021
2 tasks
@estroz estroz temporarily deployed to deploy March 17, 2021 17:49 Inactive
@estroz estroz temporarily deployed to deploy March 17, 2021 17:49 Inactive
@estroz estroz temporarily deployed to deploy March 17, 2021 17:49 Inactive
@estroz estroz temporarily deployed to deploy March 17, 2021 17:49 Inactive
@estroz estroz temporarily deployed to deploy March 17, 2021 17:49 Inactive
@estroz estroz temporarily deployed to deploy March 17, 2021 17:49 Inactive
@estroz
Copy link
Member Author

estroz commented Mar 17, 2021

config-gen docs depend on command line environment. kubernetes-sigs/kubebuilder#2097 fixes that.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@estroz estroz mentioned this pull request Mar 18, 2021
2 tasks
Signed-off-by: Eric Stroczynski <[email protected]>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@estroz estroz temporarily deployed to deploy March 18, 2021 20:41 Inactive
@estroz estroz temporarily deployed to deploy March 18, 2021 20:41 Inactive
@estroz estroz temporarily deployed to deploy March 18, 2021 20:41 Inactive
@estroz estroz temporarily deployed to deploy March 18, 2021 20:41 Inactive
@estroz estroz temporarily deployed to deploy March 18, 2021 20:41 Inactive
@estroz estroz temporarily deployed to deploy March 18, 2021 20:41 Inactive
@estroz estroz merged commit 69c8522 into operator-framework:master Mar 19, 2021
@estroz estroz deleted the feature/enable-config-gen branch March 19, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants