Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubernetes] Support kubernetes 1.29 #10820

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[kubernetes] Support kubernetes 1.29 #10820

merged 3 commits into from
Jan 31, 2024

Conversation

tmurakam
Copy link
Contributor

@tmurakam tmurakam commented Jan 22, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

Support Kubernetes v1.29

  • Make kubernetes v1.29.1 default
  • Fix cri-o role for crio-o 1.29 (Use "crio status" instead of "crio-status")
  • Remove SecCompDefault feature gate from hardening configuration

Which issue(s) this PR fixes:
Fixes #10735

Does this PR introduce a user-facing change?:

Make kubernetes v1.29.1 default
Remove SecCompDefault feature gate from hardening configuration for kubernetes 1.29

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tmurakam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024
@tmurakam
Copy link
Contributor Author

Oh, it seems that CI failed for the cri-o, because crio-status command is removed from cri-o 1.29.
I'm now investigating.

@yankay
Copy link
Member

yankay commented Jan 23, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2024
@tmurakam
Copy link
Contributor Author

Updated cri-o role for crio-o v1.29.

@tmurakam tmurakam force-pushed the feature/k8s-1.29-as-default branch 2 times, most recently from a88ca31 to dec6e8a Compare January 23, 2024 15:54
@floryut floryut mentioned this pull request Jan 24, 2024
Merged
@tmurakam
Copy link
Contributor Author

tmurakam commented Jan 28, 2024 •
edited
Loading

I'm now investigating CI errors.
For hardening tests, the following error occurred.

Jan 28 12:03:13 node1 kubelet[22219]: E0128 12:03:13.217196 22219 run.go:74] "command failed" err="failed to set feature gates from initial flags-based config: unrecognized feature gate: SeccompDefault"

Need to remove "SeccompDefault" feature gate.
kubernetes/kubernetes#121246

@tmurakam tmurakam changed the title [kubernetes] Make kubernetes 1.29.1 default [kubernetes] Support kubernetes 1.29.1 Jan 28, 2024
@tmurakam tmurakam changed the title [kubernetes] Support kubernetes 1.29.1 [kubernetes] Support kubernetes 1.29 Jan 28, 2024
@tmurakam
[cri-o]: support cri-o 1.29
4ce45d9 
Use "crio status" instead of "crio-status" for cri-o >=1.29.0
@tmurakam
Remove GAed feature gates SecCompDefault
09dbcf8 
The SecCompDefault feature gate was removed since k8s 1.29
kubernetes/kubernetes#121246
@tmurakam tmurakam requested a review from yankay January 29, 2024 10:01
@yankay
Copy link
Member

yankay commented Jan 30, 2024

Thanks a lot @tmurakam
It's so great 💕🎉👍

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
mzaian
mzaian approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @tmurakam

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, tmurakam, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 785366c into kubernetes-sigs:master Jan 31, 2024
65 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@tmurakam @pedromcpedro
[kubernetes] Support kubernetes 1.29 (kubernetes-sigs#10820)
b268f56 
* [kubernetes] Make kubernetes 1.29.1 default

* [cri-o]: support cri-o 1.29

Use "crio status" instead of "crio-status" for cri-o >=1.29.0

* Remove GAed feature gates SecCompDefault

The SecCompDefault feature gate was removed since k8s 1.29
kubernetes/kubernetes#121246
@tico88612 tico88612 mentioned this pull request Sep 15, 2024
Merged
@tico88612 tico88612 mentioned this pull request Oct 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@liupeng0518 liupeng0518 Awaiting requested review from liupeng0518

@yankay yankay Awaiting requested review from yankay

Assignees

@mzaian mzaian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes 1.29 Support
4 participants
@tmurakam @k8s-ci-robot @yankay @mzaian