Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.25] Update to last patch versions (kubernetes, helm) #11599

Conversation

robertvolkmann
Copy link
Contributor

@robertvolkmann robertvolkmann commented Oct 4, 2024

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Add the latest patch version on some core components

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default to kubernetes v1.29.9
Default to helm v3.14.4

/label tide/merge-method-merge

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

@robertvolkmann: The label(s) /label tide-merge-method-merge cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Add the latest patch version on some core components

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default to kubernetes v1.29.9
Default to containerd v1.7.22
Default to cri-o v1.29.9
Default to helm v3.14.4
/label tide-merge-method-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2024
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @robertvolkmann. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 4, 2024
@VannTen
Copy link
Contributor

VannTen commented Oct 4, 2024

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robertvolkmann, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@tico88612
Copy link
Member

/retest-failed

@VannTen
Copy link
Contributor

VannTen commented Oct 6, 2024 via email

@tico88612
Copy link
Member

Maybe this needs #11584 backported ?

I think this is the problem. #11533 (comment)

@tico88612
Copy link
Member

/remove-lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2024
@tico88612
Copy link
Member

tico88612 commented Oct 6, 2024

If you need to upgrade cri-o, you must fix the cri-o binaries name first.
You can refer to #10820 or #11533.
If you don't know how to fix it, you can revert the cri-o version and open another issue, we'll fix it some other time.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2024
@robertvolkmann robertvolkmann changed the title [2.25] Update to last patch versions (crio, kubernetes, helm) [2.25] Update to last patch versions (kubernetes, helm) Oct 10, 2024
@robertvolkmann
Copy link
Contributor Author

I removed upgrading cri-o, because it is not needed on my side.

@VannTen
Copy link
Contributor

VannTen commented Oct 10, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit ef67a74 into kubernetes-sigs:release-2.25 Oct 10, 2024
39 checks passed
@robertvolkmann robertvolkmann deleted the bump-kubernetes-versions branch October 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants