-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LB in upcloud private zone #11260
Add support for LB in upcloud private zone #11260
Conversation
Hi @davidumea. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0736580
to
9a8bf87
Compare
The failing tf-elastx_cleanup job seems unrelated to the changes made in this PR. |
/ok-to-test |
/retest-failed |
could you please sync your fork, it's 151 commit behind and there were changes in the CI |
9a8bf87
to
c44d5ce
Compare
It's synced now but pipeline seem to have timed out without any clear error. Can you trigger a rerun? |
6ac311e
to
8bb7949
Compare
8bb7949
to
8023f27
Compare
/retest |
8023f27
to
45e493c
Compare
Any updates here? |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidumea, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
When provisioning Load Balancers in UpCloud private cloud zones, the Load Balancer needs to sit in the public equivalent zone.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: