Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcloud: Added support for routers and gateways #11386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upcloud: Added support for routers and gateways #11386

wants to merge 3 commits into from

Conversation

Xartos
Copy link
Contributor

@Xartos Xartos commented Jul 17, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I will wait for this PR to be merged, then I'll rebase it. So you only need to look at this commit

Does this PR introduce a user-facing change?:

terraform: Added support for UpCloud routers and gateways

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xartos
Once this PR has been reviewed and has the lgtm label, please assign floryut for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Xartos. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2024
@yankay
Copy link
Member

yankay commented Jul 22, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024
@Xartos
Copy link
Contributor Author

Xartos commented Jul 22, 2024

I assume the failing tests aren't because of the changes in this PR?

@Xartos Xartos force-pushed the add-upcloud-router-support branch 2 times, most recently from b1dd817 to e210ad7 Compare July 25, 2024 08:52
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2024
@tico88612
Copy link
Member

Could you rebase this PR to our upstream?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@Xartos
Copy link
Contributor Author

Xartos commented Sep 11, 2024

@tico88612 Sorry for the delay, but it's rebased now

@tico88612
Copy link
Member

/retest-failed

1 similar comment
@tico88612
Copy link
Member

/retest-failed

@Xartos
Copy link
Contributor Author

Xartos commented Oct 14, 2024

Since there were some time since the last update here, I thought I rebase on upstream again

@Xartos
Copy link
Contributor Author

Xartos commented Oct 30, 2024

@tico88612 @cyclinder @ErikJiang Is there anything I can do to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyclinder cyclinder Awaiting requested review from cyclinder

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xartos @k8s-ci-robot @yankay @tico88612