Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kube-router configuration to enable metrics exposure #5416

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Add kube-router configuration to enable metrics exposure #5416

merged 1 commit into from
Dec 16, 2019

Conversation

bozzo
Copy link
Contributor

@bozzo bozzo commented Dec 8, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind feature

What this PR does / why we need it:

This PR add the ability to enable metrics endpoint on kube-router to improve monitoring and service status check. By default, the metrics endpoint is not enabled.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add configuration to enable metrics exposure on kube-router.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @bozzo!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2019
@bozzo
Copy link
Contributor Author

bozzo commented Dec 11, 2019

/assign @ant31

@Miouge1
Copy link
Contributor

Miouge1 commented Dec 13, 2019

@bozzo we're having difficulties to maintain the kube-router CNI support in Kubespray (see #5432) would you be able to help?

@Miouge1 Miouge1 added this to the 2.13 milestone Dec 13, 2019
@bozzo
Copy link
Contributor Author

bozzo commented Dec 13, 2019

@Miouge1 yes, I can help to maintain it.

@Miouge1
Copy link
Contributor

Miouge1 commented Dec 16, 2019

@bozzo brilliant!

This PR looks good to me: it's an optional change (disabled by default), so it shouldn't be disruptive.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bozzo, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit c0b262a into kubernetes-sigs:master Dec 16, 2019
erulabs added a commit to kubesail/kubespray that referenced this pull request Dec 22, 2019
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
262e902 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add script for generating binary hashes (kubernetes-sigs#5470)
  Bump yamllint and ansible-lint versions (kubernetes-sigs#5421)
  Remove inline shell in YAML for vagrant-validate (kubernetes-sigs#5386)
  Remove GCE tests files (kubernetes-sigs#5459)
  [docs] Add CI matrix and script (kubernetes-sigs#5461)
  Update CNI plugins to v0.8.3 (kubernetes-sigs#5453)
  Add kube-router configuration to enable metrics exposure (kubernetes-sigs#5416)
  fix typo (kubernetes-sigs#5452)
  cri-o: redhat.yml - remove package cri-tools (kubernetes-sigs#5444)
  Update CI to use v2.12.0 image and update release process (kubernetes-sigs#5448)
  Bump nodelocaldns version to 1.15.8 (kubernetes-sigs#5447)
  Add Helm 3.x support (kubernetes-sigs#5441)
  Update aws tf (kubernetes-sigs#5435)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 20, 2020
@bozzo @LuckySB
Add kube-router configuration to enable metrics exposure (kubernetes-…
f4c2cd9 
…sigs#5416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadswen chadswen Awaiting requested review from chadswen

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@ant31 ant31

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
4 participants
@bozzo @k8s-ci-robot @Miouge1 @ant31