Update aws tf #5435
Merged
Update aws tf #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfraz, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
erulabs
added a commit
to kubesail/kubespray
that referenced
this pull request
Dec 22, 2019
* 'master' of https://github.com/kubernetes-sigs/kubespray: Add script for generating binary hashes (kubernetes-sigs#5470) Bump yamllint and ansible-lint versions (kubernetes-sigs#5421) Remove inline shell in YAML for vagrant-validate (kubernetes-sigs#5386) Remove GCE tests files (kubernetes-sigs#5459) [docs] Add CI matrix and script (kubernetes-sigs#5461) Update CNI plugins to v0.8.3 (kubernetes-sigs#5453) Add kube-router configuration to enable metrics exposure (kubernetes-sigs#5416) fix typo (kubernetes-sigs#5452) cri-o: redhat.yml - remove package cri-tools (kubernetes-sigs#5444) Update CI to use v2.12.0 image and update release process (kubernetes-sigs#5448) Bump nodelocaldns version to 1.15.8 (kubernetes-sigs#5447) Add Helm 3.x support (kubernetes-sigs#5441) Update aws tf (kubernetes-sigs#5435)
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jan 20, 2020
* update aws tf to function as expected * update tf version * update syntax for tf v0.12 * update tf version in readme * update per tf for v0.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
updates tf for aws provisioning given changing behavior with terraform v0.12. See: hashicorp/terraform#19140
Which issue(s) this PR fixes:
Fixes #5430
Special notes for your reviewer:
There was a change in tf 0.12 that broke previous behavior. This also updates aws tf docs to reflect the change.
For context: here's the changes for tf v0.8.7 to 0.11 #5431
Does this PR introduce a user-facing change?: