Update cni plugins when flannel is ready.

[mJace]

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR will update cni plugins when flannel pod is ready.
Before this PR, when installation k8s using kubespray with flannel, the cni plugins will stick on a certain old version. And not the new version as it claimed to be in kubespray document.

Which issue(s) this PR fixes:

Fixes #5562

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @mJace!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mJace
To complete the pull request process, please assign mirwan
You can assign the PR to them by writing /assign @mirwan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mJace]

I signed it

[LuckySB]

flannel copied binary to /opt/cni/bin from install-cni container (mage: quay.io/coreos/flannel-cni:v0.3.0`, so that everything in the directory /opt/cni/bin will be overwritten upon restart flannel pod

flannel manifests in kubespray are out of date.
we need to update them to actual version from k8s docs
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/#pod-network
https://raw.githubusercontent.com/coreos/flannel/2140ac876ef134e0ed5af15c65e414cf26827915/Documentation/kube-flannel.yml

[mJace]

@LuckySB install-cni container in flannel pod will copy the cni binary to /opt/cni/bin, but not exactly overwrite everything in that directory.
log.txt
You can see. flannel only overwrite the bridge cnitool dhcp flannel host-local ipvlan loopback...
but those static sbr multus ... stays the same.

[mJace]

@LuckySB And I notice that the new version of install-cni in the yaml you give, will not copy any cni-plugins to /opt/cin/bin anymore including flannel binary.

[LuckySB]

@mJace yes. current legacy install cni contain old version 0.3.0 of common cni plugin.

change install procedure to:

• extract cni plugin from archive (latest version of flannel plugin already exists in this archive)
• deploy flannel from patched manifest (I think we need to change the name daemon set)

[floryut]

No longer need with #5937, right ? comment & reopen if I'm wrong

[floryut]

/close

[k8s-ci-robot]

@floryut: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.