Update Flannel manifests, install script and version (0.12) + fix tests scripts #5937

floryut · 2020-04-10T19:22:24Z

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

Update flannel version to 0.12.0
Update manifests from their repo (lots of changes)
Added cni binaries to ansible role (you were right at least loopback was missing)
Add the workaround to fix flannel bug Disable tx and rx offloading on VXLAN interfaces flannel-io/flannel#1282

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2020-04-10T19:22:37Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LuckySB · 2020-04-10T21:58:42Z

@floryut we need rewrite code of install flannel
#5598 (comment)

flannel now not sold with flannel-cni container, so cni plugins binary should copy as in cillium tasks

floryut · 2020-04-11T07:22:50Z

@floryut we need rewrite code of install flannel
#5598 (comment)

flannel now not sold with flannel-cni container, so cni plugins binary should copy as in cillium tasks

Oh crap, thanks man, will take a look anyhow it's a big wip pr, will try some things with this test

Miouge1 · 2020-04-11T07:27:28Z

Found the following GitHub issues about Flannel on k8s v1.17 with DNS problems:
flannel-io/flannel#1243 and kubernetes/kubernetes#87852

Miouge1 · 2020-04-11T07:28:41Z

If there is a known problem with Flannel on v1.17, then we could make a note of it in Kubespray v2.13 release note and backport any fix that comes upstream?

LuckySB · 2020-04-11T23:22:16Z

kubernetes/kubernetes#90084

I tried different versions of flannel
and I think that the problem is in the kube-proxy and it has been around for a very long time

floryut · 2020-04-12T05:26:01Z

Here what I've done so far

Update flannel version to 0.12.0
Update manifests from their repo (lots of changes)
Added cni binaries to ansible role (you were right at least loopback was missing)
Put a hack to add the route in the networking test

With that the flannel test works (test green), where do you want to go from there @Miouge1 @LuckySB ?

Miouge1

Let's go ahead with this

Great work @floryut !

/lgtm
/approve

k8s-ci-robot · 2020-04-14T13:40:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Miouge1 · 2020-04-14T13:42:20Z

/ok-to-test

LuckySB · 2020-04-14T15:36:52Z

/lgtm

floryut · 2020-04-14T15:41:46Z

/lgtm

Thanks, forgot the {% if apparmor_enabled %} check so had to repush

LuckySB · 2020-04-14T16:51:28Z

/lgtm cancel

LuckySB · 2020-04-14T16:51:48Z

/lgtm

Thanks, forgot the {% if apparmor_enabled %} check so had to repush

wait to repush

offloading in networking test

Miouge1 · 2020-04-15T06:44:04Z

The apparmor condition has been added so let's roll

/lgtm

rhockenbury · 2020-04-15T15:15:23Z

roles/network_plugin/flannel/templates/cni-flannel.yml.j2

    spec:
      priorityClassName: system-node-critical
      serviceAccountName: flannel
-      nodeSelector:


I realize I'm late to the party (this was already merged), but the nodeselector is needed for those who might be running windows nodes in their clusters.

Hum wasn't sure that latest k8s version and flannel weren't compatible with windows.
But if you're sure let's add it back then :)

…ts scripts (kubernetes-sigs#5937) * Add CI_TEST_VARS to tests * Update flannel to 0.12.0 (with new manifests) and disable tx/rx offloading in networking test

k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Apr 10, 2020

k8s-ci-robot requested review from bozzo and holmsten April 10, 2020 19:22

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2020

floryut force-pushed the flannel_1.17 branch from 5321ed0 to c93476c Compare April 10, 2020 19:24

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 10, 2020

floryut changed the title ~~Test flannel 1.17~~ [WIP] Test flannel 1.17 Apr 10, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2020

floryut force-pushed the flannel_1.17 branch from c93476c to e6c423e Compare April 10, 2020 19:56

floryut force-pushed the flannel_1.17 branch from e6c423e to a9c4a34 Compare April 11, 2020 13:25

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2020

floryut force-pushed the flannel_1.17 branch 6 times, most recently from 20c5a11 to 754a55e Compare April 11, 2020 20:54

floryut force-pushed the flannel_1.17 branch 3 times, most recently from ba0b71f to 26bc7e6 Compare April 12, 2020 11:34

floryut changed the title ~~[WIP] Update Flannel manifests, install script and version (0.12) + fix tests scripts~~ Update Flannel manifests, install script and version (0.12) + fix tests scripts Apr 14, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020

floryut requested a review from Miouge1 April 14, 2020 13:27

floryut force-pushed the flannel_1.17 branch from eac6fbd to 93bb196 Compare April 14, 2020 13:29

Miouge1 approved these changes Apr 14, 2020

View reviewed changes

k8s-ci-robot assigned Miouge1 Apr 14, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 14, 2020

floryut force-pushed the flannel_1.17 branch from 93bb196 to 83a5408 Compare April 14, 2020 15:10

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020

k8s-ci-robot assigned LuckySB Apr 14, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020

Update flannel to 0.12.0 (with new manifests) and disable tx/rx

ac28454

offloading in networking test

floryut force-pushed the flannel_1.17 branch from 83a5408 to ac28454 Compare April 14, 2020 18:12

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2020

k8s-ci-robot merged commit 58f4850 into kubernetes-sigs:master Apr 15, 2020

This was referenced Apr 15, 2020

Update cni plugins when flannel is ready. #5598

Closed

When using flannel, cni plugins will stick on old version. #5562

Closed

rhockenbury reviewed Apr 15, 2020

View reviewed changes

zhengtianbao mentioned this pull request Dec 24, 2021

Should it be copy flannel binary to host? #8333

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Flannel manifests, install script and version (0.12) + fix tests scripts #5937

Update Flannel manifests, install script and version (0.12) + fix tests scripts #5937

floryut commented Apr 10, 2020 •

edited

Loading

k8s-ci-robot commented Apr 10, 2020

LuckySB commented Apr 10, 2020 •

edited

Loading

floryut commented Apr 11, 2020

Miouge1 commented Apr 11, 2020

Miouge1 commented Apr 11, 2020

LuckySB commented Apr 11, 2020

floryut commented Apr 12, 2020 •

edited

Loading

Miouge1 left a comment

k8s-ci-robot commented Apr 14, 2020

Miouge1 commented Apr 14, 2020

LuckySB commented Apr 14, 2020

floryut commented Apr 14, 2020

LuckySB commented Apr 14, 2020

LuckySB commented Apr 14, 2020

Miouge1 commented Apr 15, 2020

rhockenbury Apr 15, 2020

floryut Apr 15, 2020

Update Flannel manifests, install script and version (0.12) + fix tests scripts #5937

Update Flannel manifests, install script and version (0.12) + fix tests scripts #5937

Conversation

floryut commented Apr 10, 2020 • edited Loading

k8s-ci-robot commented Apr 10, 2020

LuckySB commented Apr 10, 2020 • edited Loading

floryut commented Apr 11, 2020

Miouge1 commented Apr 11, 2020

Miouge1 commented Apr 11, 2020

LuckySB commented Apr 11, 2020

floryut commented Apr 12, 2020 • edited Loading

Miouge1 left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 14, 2020

Miouge1 commented Apr 14, 2020

LuckySB commented Apr 14, 2020

floryut commented Apr 14, 2020

LuckySB commented Apr 14, 2020

LuckySB commented Apr 14, 2020

Miouge1 commented Apr 15, 2020

rhockenbury Apr 15, 2020

Choose a reason for hiding this comment

floryut Apr 15, 2020

Choose a reason for hiding this comment

floryut commented Apr 10, 2020 •

edited

Loading

LuckySB commented Apr 10, 2020 •

edited

Loading

floryut commented Apr 12, 2020 •

edited

Loading