fix containerd config toml for insecure registries

[1eedaegon]

here is the config about insecure registries for containerd.

containerd_insecure_registries:
  "192.168.x.x:8080":
    - "http://192.168.x.x:8080"

the rendered /etc/containerd/config.toml contains:

    [plugins."io.containerd.grpc.v1.cri".registry.configs."http://192.168.x.x:8080".tls]
      insecure_skip_verify = true

but it needs to be:

    [plugins."io.containerd.grpc.v1.cri".registry.configs."192.168.x.x:8080".tls]
      insecure_skip_verify = true

because insecure_registries template has registry address instead of registry name

diff --git a/roles/container-engine/containerd/templates/config.toml.j2 b/roles/container-engine/containerd/templates/config.toml.j2
index c1bda12b..096dea40 100644
--- a/roles/container-engine/containerd/templates/config.toml.j2
+++ b/roles/container-engine/containerd/templates/config.toml.j2
@@ -57,8 +57,8 @@ oom_score = {{ containerd_oom_score }}
         [plugins."io.containerd.grpc.v1.cri".registry.mirrors."{{ registry }}"]
           endpoint = ["{{ ([ addr ] | flatten ) | join('","') }}"]
 {% endfor %}
-{% for addr in containerd_insecure_registries.values() | flatten | unique %}
-        [plugins."io.containerd.grpc.v1.cri".registry.configs."{{ addr }}".tls]
+{% for registry in containerd_insecure_registries.keys() %}
+        [plugins."io.containerd.grpc.v1.cri".registry.configs."{{ registry }}".tls]
           insecure_skip_verify = true
 {% endfor %}
 {% endif %}

What type of PR is this?
/kind bug

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fixes /etc/containerd/config.toml generation for insecure registries.

Which issue(s) this PR fixes:

Fixes #9371 #9207 #9653

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: 1eedaegon / name: Gon (77a9423)

[k8s-ci-robot]

Welcome @1eedaegon!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @1eedaegon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 1eedaegon
Once this PR has been reviewed and has the lgtm label, please assign chadswen for approval by writing /assign @chadswen in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[1eedaegon]

/kind bug

[1eedaegon]

/easycla

[yankay]

/ok-to-test

[ErikJiang]

@1eedaegon 😁Could you please rebase as #9657 has fixed the CI, thank you.

[1eedaegon]

@ErikJiang
I fixed it :)

If you don't mind could you please tell me how to sign up with EasyCLA?
authorization doesn't seem to work for me even after signing multiple times. 🤔

[1eedaegon]

/check-cla

[1eedaegon]

/retest

[floryut]

@ErikJiang I fixed it :)

If you don't mind could you please tell me how to sign up with EasyCLA? authorization doesn't seem to work for me even after signing multiple times. 🤔

Did you do it using your @mondrian.ai email ?

[1eedaegon]

@ErikJiang I fixed it :)
If you don't mind could you please tell me how to sign up with EasyCLA? authorization doesn't seem to work for me even after signing multiple times. 🤔

Did you do it using your @mondrian.ai email ?

Thanks for your comment. @floryut

No. I am working at Mondrian AI, but my github email is **[email protected].
I submitted both personal and corporate CLA using personal email thinking EasyCLA wasn't working.
I just changed my LFX account primary email to my company email like [email protected].
Is this the right way?

[1eedaegon]

/check-cla

[floryut]

@ErikJiang I fixed it :)
If you don't mind could you please tell me how to sign up with EasyCLA? authorization doesn't seem to work for me even after signing multiple times. 🤔

Did you do it using your @mondrian.ai email ?

Thanks for your comment. @floryut

No. I am working at Mondrian AI, but my github email is **[email protected]. I submitted both personal and corporate CLA using personal email thinking EasyCLA wasn't working. I just changed my LFX account primary email to my company email like [email protected]. Is this the right way?

Ok it's just that your commit is set with this email
https://patch-diff.githubusercontent.com/raw/kubernetes-sigs/kubespray/pull/9651.patch

[1eedaegon]

@ErikJiang I fixed it :)
If you don't mind could you please tell me how to sign up with EasyCLA? authorization doesn't seem to work for me even after signing multiple times. 🤔

Did you do it using your @mondrian.ai email ?

Thanks for your comment. @floryut
No. I am working at Mondrian AI, but my github email is **[email protected]. I submitted both personal and corporate CLA using personal email thinking EasyCLA wasn't working. I just changed my LFX account primary email to my company email like [email protected]. Is this the right way?

Ok it's just that your commit is set with this email https://patch-diff.githubusercontent.com/raw/kubernetes-sigs/kubespray/pull/9651.patch

@floryut
You are my savior 😭
Thank you!!!

[1eedaegon]

/retest

[yankay]

HI @1eedaegon

The issue may be fixed by the #9729 :-)

[1eedaegon]

HI @1eedaegon

The issue may be fixed by the #9729 :-)

Thanks. better than this commit =]
now close this PR