Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes VM creation bug in Ubuntu 20 Calico AIO test #9657

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

luksi1
Copy link
Contributor

@luksi1 luksi1 commented Jan 11, 2023

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

packet_ubuntu20-calico-aio is failing

Which issue(s) this PR fixes:

Fixes #9660

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Adds template file as Ansible fact for creating VMs for testing and then applies the fact as stdin to `kubectl apply` to workaround this bug

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @luksi1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 11, 2023
@luksi1 luksi1 marked this pull request as draft January 11, 2023 19:59
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2023
@luksi1 luksi1 force-pushed the start_vms_for_ci_job branch 11 times, most recently from d76020b to 4d290d8 Compare January 12, 2023 14:41
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2023
@luksi1 luksi1 changed the title Debugging Fixes VM creation bug in Bbuntu 20 Calico AIO test Jan 12, 2023
@luksi1 luksi1 changed the title Fixes VM creation bug in Bbuntu 20 Calico AIO test Fixes VM creation bug in Ubuntu 20 Calico AIO test Jan 12, 2023
@luksi1 luksi1 marked this pull request as ready for review January 12, 2023 20:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2023
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luksi1 Thank you for this one 👍
This bug is freaking weird.. I can't pinpoint the root cause, I would have gone with a package update but the old pipeline image from 2.20, also does this, so ... 🤷

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, luksi1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2023
@luksi1
Copy link
Contributor Author

luksi1 commented Jan 13, 2023

@floryut What were you thinking? Bumping the pipeline image or did you have another package in mind?

@floryut
Copy link
Member

floryut commented Jan 13, 2023

@floryut What were you thinking? Bumping the pipeline image or did you have another package in mind?

What do you mean ? the pipeline image is now built at each pipeline start, so good to go.

@luksi1 luksi1 force-pushed the start_vms_for_ci_job branch 2 times, most recently from ffc172a to e4c435c Compare January 14, 2023 09:20
@luksi1
Copy link
Contributor Author

luksi1 commented Jan 14, 2023

PIpeline is now successful, so it would be good if we could get this merged as soon as possible.

@floryut
Copy link
Member

floryut commented Jan 14, 2023

PIpeline is now successful, so it would be good if we could get this merged as soon as possible.

let's go, as it's blocking other PR and the release.

Thank a lot @luksi1, really

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4ad56e2 into kubernetes-sigs:master Jan 14, 2023
@floryut floryut added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 14, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packet_ubuntu20-calico-aio job is failing
4 participants