Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIG Docs chair transition #171

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

zacharysarah
Copy link

ref: kubernetes/website#23797

🟢 OK TO MERGE 🟢

Don't merge this PR until all conditions are true:

  • all governance pieces of #23797 are approved
  • Date equal to or later than September 15th, 2020

Description

This PR updates repo permissions and contacts for @irvifa becoming a chair and @zacharysarah transitioning to chair emeritus.

/assign @irvifa @jimangel @kbarnard10

@k8s-ci-robot
Copy link
Contributor

@zacharysarah: GitHub didn't allow me to assign the following users: irvifa.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

ref: kubernetes/website#23797

🟢 OK TO MERGE 🟢

Don't merge this PR until all conditions are true:

  • all governance pieces of #23797 are approved
  • Date equal to or later than September 15th, 2020

Description

This PR updates repo permissions and contacts for @irvifa becoming a chair and @zacharysarah transitioning to chair emeritus.

/assign @irvifa @jimangel @kbarnard10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 27, 2020
@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2020
@zacharysarah
Copy link
Author

zacharysarah commented Sep 27, 2020

@irvifa 👋 Looks like you need to open a PR in kubernetes/community to add yourself to the kubernetes-sigs org.

@irvifa
Copy link
Member

irvifa commented Sep 28, 2020

Hi @zacharysarah is this under sig docs cmiiw?

@zacharysarah
Copy link
Author

@irvifa Yes, this repo is how SIG Docs currently generates API reference docs. (Hopefully not for too much longer.)

@irvifa
Copy link
Member

irvifa commented Sep 28, 2020

@zacharysarah Noted then. I already create an issue and PR for this.

@irvifa
Copy link
Member

irvifa commented Oct 2, 2020

/retest

@irvifa
Copy link
Member

irvifa commented Oct 2, 2020

Hi @zacharysarah do we need to do something about the k8s label? Since I already merged my PR to satisfy the condition

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2020
@jimangel
Copy link
Member

/remove-lifecycle stale
/verify-owners

@k8s-ci-robot k8s-ci-robot removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 17, 2021
@jimangel
Copy link
Member

/lgtm
/approve
(take two!)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jimangel,zacharysarah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a05489 into kubernetes-sigs:master Jan 17, 2021
@zacharysarah zacharysarah deleted the chair-emeritus branch January 17, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants