Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feloy as reviewer/approver #194

Merged
merged 1 commit into from
Jan 18, 2021
Merged

add feloy as reviewer/approver #194

merged 1 commit into from
Jan 18, 2021

Conversation

kbhawkey
Copy link
Contributor

@kbhawkey kbhawkey commented Jan 5, 2021

Add @feloy to OWNERS file.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 5, 2021
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jan 5, 2021

/hold for review
@feloy has contributed the new resources generator and is a core reference documentation contributor.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2021
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jan 5, 2021

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jan 5, 2021

Looks like I am missing a step in this process.

@zacharysarah
Copy link

@kbhawkey 👋🏻

Looks like I am missing a step in this process.

Based on the bot reply, I think @feloy needs to join the kubernetes-sigs org before he can be an OWNER.

@feloy
Copy link
Contributor

feloy commented Jan 6, 2021

@zacharysarah @kbhawkey can you sponsor me to join the kubernetes-sigs org?

@zacharysarah
Copy link

@feloy

can you sponsor me to join the kubernetes-sigs org?

Gladly. 👍🏻

@kbhawkey
Copy link
Contributor Author

kbhawkey commented Jan 6, 2021

can you sponsor me to join the kubernetes-sigs org?

@feloy, Yes, that's great!

@feloy
Copy link
Contributor

feloy commented Jan 6, 2021

I've created the issue to join kubernetes-sigs: kubernetes/org#2404

@kbhawkey
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2021
@jimangel
Copy link
Member

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 17, 2021
@jimangel
Copy link
Member

My approval here created a conflict, sorry @kbhawkey. Once conflict is resolved this is good to go!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2021
@zacharysarah
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5d335af into kubernetes-sigs:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimangel jimangel Awaiting requested review from jimangel

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@zacharysarah zacharysarah

@jimangel jimangel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbhawkey @zacharysarah @feloy @jimangel @k8s-ci-robot