Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert error message changes #96

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

liggitt
Copy link

@liggitt liggitt commented Oct 20, 2023

Reverts some error message issues introduced since v1.3.0

The added unit test passes on the current released tag (v1.3.0) and the error message changes make it pass on master as well.

xref #76 (comment)

testing in k/k in kubernetes/kubernetes#121407 - passed ✅

testing in kustomize in kubernetes-sigs/kustomize#5406 - passed ✅

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2023
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023
@liggitt liggitt mentioned this pull request Oct 20, 2023
Changes in PR 65 modified error messages. While some of the changes read better,
also produced duplicate prefixes (like "error converting YAML to JSON: error converting YAML to JSON:").

Even the improvements broke downstream unit tests relying on exact prefix matching.

Reverting the error message changes before tagging a new release to avoid disrupting consumers
until we consider the impact of these changes more thoroughly.
@liggitt liggitt changed the title WIP Revert error message changes Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2023
@natasha41575
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@liggitt
Copy link
Author

liggitt commented Oct 23, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3566774 into kubernetes-sigs:master Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants