Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert error message changes #96

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Revert error message changes #96

merged 1 commit into from
Oct 23, 2023
+139 −6

Commits on Oct 23, 2023

  1. Revert error message changes 

    Changes in PR 65 modified error messages. While some of the changes read better,
also produced duplicate prefixes (like "error converting YAML to JSON: error converting YAML to JSON:").

Even the improvements broke downstream unit tests relying on exact prefix matching.

Reverting the error message changes before tagging a new release to avoid disrupting consumers
until we consider the impact of these changes more thoroughly.
    @liggitt
    liggitt committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    3f79f32 View commit details
    Browse the repository at this point in the history