-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ProvisioningRequest v1 client #7195
ProvisioningRequest v1 client #7195
Conversation
cluster-autoscaler/ (remove go.mod)
This reverts commit 850bd64.
Tested conversion in a real cluster by creating a few v1beta1 ProvisioningRequests and verifying they're processed as expected by the version of CA built from this PR. |
/unhold |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska, MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Adds ProvisioningRequest v1 API client.
Special notes for your reviewer:
This PR has several commits because the process of generating client for v1 wasn't straightforward. Not squashing for transparency and future reference. I haven't found a better workaround than removing and adding
apis/
module.Steps to generate client:
k8s.io/codegen
hack/update-codegen.sh
as it was outdated (assumed/vendor
and used old scripts which no longer exist in codegen)apis/
into a regular package. Normallycluster-autoscaler/apis
is a module that can be imported standalone, but it lives withincluster-autoscaler/
, and codegen is very unhappy about it.staging/
not being a module, and instead being mirrored in a separate repo.main module (k8s.io/autoscaler/cluster-autoscaler) does not contain package k8s.io/autoscaler/cluster-autoscaler/apis/provisioningrequest/autoscaling.x-k8s.io/v1beta1
.hack/update-codegen.sh
hack/update-codegen.sh
apis/
a module again (reverted second commit)Does this PR introduce a user-facing change?
/hold
/cc @MaciekPytel @mwielgus