-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate ProvisioningRequest CRD for v1 #7223
Regenerate ProvisioningRequest CRD for v1 #7223
Conversation
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
For future reference: the same go module workarounds as in #7195 were necessary, I just didn't keep the commits this time since this is already explained in the previous PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksandra-malinowska, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick cluster-autoscaler-release-1.31 |
@aleksandra-malinowska: new pull request created: #7316 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
/kind api-change
What this PR does / why we need it:
In #7195 ProvisioningRequest API was bumped to v1, but CRD wasn't upgraded. CA 1.31 won't work without upgraded CRD.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/cc @MaciekPytel @mwielgus