-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 3rd party device monitoring plugins #606
Comments
@dashpole this has been added to the 1.12 tracking sheet. Thank you @justaugustus please add relevant tags to this issue |
@kacole2 all set! |
@dashpole looks like design proposal link should be this one: https://docs.google.com/document/d/1NYnqw-HDQ6Y3L_mk85Q3wkxDtGNWTxpsedsgw4NgWpg/edit |
Agreed, that makes more sense |
/assign @dashpole |
Hey there! @dashpole I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it? |
@zparnold here is the docs pr placeholder: kubernetes/website#9945 |
Thank you @dashpole! |
@dashpole -- |
It can be removed from the milestone |
Got it. Thanks for the update! |
Hi @dashpole Please take a moment to ping @kacole2 so it can be included in the 1.13 Enhancements Tracking Sheet if it's going to make it. Thanks! |
/milestone v1.13 |
@dashpole could you please let us know whats pending for this feature to go to Alpha in 1.13. Do you have a list of pending PRs or issues you can point us to. Thanks |
@dashpole there has been no communication on the status. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me know where we stand. Thanks! |
KEP: kubernetes/community#2454 should be merged soon, as it is approved by the required people. Once that happens, Ill open the implementation PR, and get working on docs. I still expect this to land in 1.13. |
Hello @ffromani @dashpole 👋, Enhancements team here. Just checking in as we approach enhancements freeze on Thursday, 16th June 2023. Looks like this enhancement is Here's where this enhancement currently stands:
For this KEP, we would simply need to update the following:
The status of this enhancement is marked as |
Hi @Atharva-Shinde , thanks for reaching out. The latest pending item for this work, which slipped in 1.28, was actually moving all the FGs to locked (kubernetes/kubernetes#116525). The PRR for GA stage was already passed: #3791 (comment) |
@ffromani Thanks for confirming! With all the requirements fulfilled, I will mark this enhancement as |
Hello @dashpole 👋, 1.28 Docs Lead here. Does this enhancement work planned for 1.28 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
Hi, I'm handling the GA graduation. Please find the relevant PR: kubernetes/website#41804 |
Hey again @ffromani 👋 Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 . Here’s the enhancement’s state for the upcoming code freeze:
As per your comment above I believe that there are no active PR/s remaining that needs to be merged in k/k. But still if there are any k/k related PR/s that we should be tracking for this KEP please link them in the issue description above. Also please keep the issue description up-to-date with all the PR/s that are associated with this KEP. As always, we are here to help if any questions come up. Thanks! |
…g post about it. I'm intentionally covering multiple related enhancements with a single blog post. Enhancement: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
Hi @Atharva-Shinde , I'm writing this so I can confirm that all relevant PRs (KEP, code, docs) are merged and from my POV everything looks good for this enhancement. Because I don't have edit access to this (the original) issue, I'm keeping the state up to date in #3743 - the latter covers the GA graduation of this feature. |
Hey @dashpole @ffromani 👋 Enhancements Lead here,
With all implementation PRs merged as per the issue description from this issue and issue number #3743, this enhancement is now |
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
I'm intentionally covering multiple related enhancements with a single blog post. Enhancements: - kubernetes/enhancements#606 - kubernetes/enhancements#2403 - kubernetes/enhancements#3743 Signed-off-by: Francesco Romani <[email protected]>
/remove-label lead-opted-in |
/close mirroring the status reported in #3743, all work here is done, so I think we can close this issue. |
@ffromani: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Feature Description
One-line feature description (can be used as a release note): Support 3rd party device monitoring plugins
Primary contact (assignee): @ffromani
Responsible SIGs: sig-node
Design proposal link (community repo): KEP: Support Device Monitoring community#2454
KEP: 606-compute-device-assignment
Link to e2e and/or unit tests: Coming Soon
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @vikaschoudhary16 @jiayingz
Approver (likely from SIG/area to which feature belongs): @derekwaynecarr
Feature target (which target equals to which milestone):
Stable
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):/kind feature
/sig node
The text was updated successfully, but these errors were encountered: