podresources API is GA now #4043
Conversation
the KEP is fully GA Signed-off-by: Francesco Romani <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
sig/node
|
xref: #3980 |
|
@kubernetes/release-managers this would close the KEP issue and remove it potentially from any tracking board you might have. Should we do it now or after release 1.28 is cut? |
|
/hold not sure the process here. PR itself lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
|
@SergeyKanzhelev Release Managers are not responsible for the enhancements boards, please check about that with @kubernetes/release-team-enhancements and @kubernetes/release-team-leads |
|
@xmudrii thank you for including the correct teams. |
|
Hey @SergeyKanzhelev if this enhancement is intended to complete as GA-implemented through the v1.28 release, we should opt-in. So can you add the
Even if this PR gets merged and the issue closes, the enhancement won't be removed from our enhancements tracking board as it would still have |
|
thank you! Label /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ffromani, SergeyKanzhelev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -6,7 +6,7 @@ authors: | |||
| - "@renaudwastaken" | |||
| owning-sig: sig-node | |||
| participating-sigs: [] | |||
| status: implementable | |||
| status: implemented | |||
There was a problem hiding this comment.
Did it already went to stable in 1.27?
Or is the plan to promote it to stable in 1.28?
If the former, then it should remain implementable until 1.28 [with this being stable] is out to the world.
If the latter, the milestone "stable" below should be changed to 1.27...
There was a problem hiding this comment.
the PR to lock the feature gate was merged to 1.28. Based on this comment #4043 (comment) we can merge it now. I'm fine either way.
There was a problem hiding this comment.
Thanks @wojtek-t for the clarification. The work is GA in 1.28 . We already merged the change because all the actual work happened in the 1.27 cycle. The only pending item left was to lock the FG, which missed the deadline because of the long merge queue on the last day of the 1.27 code freeze. I don't mind closing this PR and resubmitting few months in the future.
There was a problem hiding this comment.
Based on this comment #4043 (comment) we can merge it now.
I don't fully agree here.
I really hope it won't be the case here, but I've seen at least a few cases where something was claimed done and then reverted later and finally missed the release.
So while the chances of that in this cases are super low, I still believe we should actually not workaround the process that we have and mark the KEPs as implemented only after the release in which the feature went stable is actually already released. [So in this case, when 1.28 is out.]
Doing it differently in different cases is simply confusing people around - clear rules always help in my opinion.
There was a problem hiding this comment.
Sorry for the confusion. I addressed the doubt of whether the enhancement will be removed from tracking board if this PR was merged and the issue closes, but I deduced by looking at the PR title that this PR is changing its stage to stable for 1.28 release which I now see is not the case. The status, in case of stable enhancements, should be set to implemented only after the release.
Fixes #606