Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/kepval: enable PRR check for implemented KEPs #3007

Merged
merged 12 commits into from
Oct 20, 2021
Merged

pkg/kepval: enable PRR check for implemented KEPs #3007

merged 12 commits into from
Oct 20, 2021

Commits on Oct 13, 2021

  1. pkg/kepval: require prr check for implemented keps 

    Tests will fail at this commit, subsequent commits update data to
resolve the failures.
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    c48b033 View commit details
    Browse the repository at this point in the history

  2. hack: add edit-keps.py 

    helper script to edit keps en-masse, hardcoded in this case to make a
guess at stage and latest-milestone for keps with status: implemented

    ./hack/edit-keps.py --keps-dir ./keps
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    ed17414 View commit details
    Browse the repository at this point in the history

  3. keps: add latest-milestone and stage to implemented KEPs 

    Added via hack/edit-keps.py
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    761668f View commit details
    Browse the repository at this point in the history

  4. keps/sig-cli: 2206 status: implementable 

    Looking through history, consensus seemed to be that implemented status
is reserved for KEPs that have `stage: stable`, so this should remain at
implementable
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    105f034 View commit details
    Browse the repository at this point in the history

  5. keps/sig-release: 1498 stage: stable 

    This is implemented so its stage should be stable
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    dd3cb63 View commit details
    Browse the repository at this point in the history

  6. keps/sig-release: 0000 stage: stable 

    This is implemented so its stage should be stable
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6411a4d View commit details
    Browse the repository at this point in the history

  7. keps/sig-testing: 2539 status: implementable 

    It seems consensus is that implemented should only be used once stage is
stable. We're not there yet on this KEP, so drop back to implementable
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    cf70bb1 View commit details
    Browse the repository at this point in the history

  8. keps/prod-readiness: add sig-architecture/1143 

    This was marked as stable in v1.21 as of 2021-04-xx. The PRR check
is only valid for anything v1.21 or later, but wasn't marked as
required until 2021-05-05.

I'm not sure if this never went through review, was previously exempt,
etc.
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    a5a7071 View commit details
    Browse the repository at this point in the history

  9. keps/prod-readiness: add sig-testing/2539 

    This went to beta in v1.21 before PRR was mandated as required. It's a
tooling/process KEP that doesn't affect the contents of a kubernetes
release, so I expect this to be a rubber stamp
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3f4b245 View commit details
    Browse the repository at this point in the history

  10. keps/prod-readiness: add sig-cli/2206 

    This was retroactively marked as implemented @ beta during v1.22. It's
not clear to me whether this should have gone through PRR
    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    a28ce6d View commit details
    Browse the repository at this point in the history

  11. api: validate status:implemented == stage:stable

    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6f464ad View commit details
    Browse the repository at this point in the history

  12. keps: add prod-readiness and stage:stable for sig-auth/2097

    @spiffxp
    spiffxp committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    4b78b37 View commit details
    Browse the repository at this point in the history