kubernetes · k8s-ci-robot · Oct 20, 2021 · Oct 8, 2021 · Oct 8, 2021 · Oct 8, 2021
diff --git a/api/proposal.go b/api/proposal.go
@@ -257,6 +257,9 @@ func (k *KEPHandler) Validate(p *Proposal) []error {
 	if err := p.Stage.IsValid(); err != nil {
 		allErrs = append(allErrs, err)
 	}
+	if p.Status == ImplementedStatus && p.Stage != StableStage {
+		allErrs = append(allErrs, fmt.Errorf("status:implemented implies stage:stable but found: %v", p.Stage))
+	}
 	return allErrs
 }
 

diff --git a/hack/edit-keps.py b/hack/edit-keps.py
@@ -0,0 +1,103 @@
+#!/usr/bin/env python3
+
+# Copyright 2021 The Kubernetes Authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Edit KEPs en-masse by round-tripping them through ruamel.yaml
+
+This is not intended for general usage, because:
+- many keps have different formatting, and we're not at a point where
+  we can enforce formatting standards, so this is almost guaranteed
+  to introduce formatting change noise
+- the idea is to manually edit this file with the specific edit to be
+  done, rather that developing a general purpose language to do this
+"""
+
+import argparse
+import glob
+
+from os import path
+
+import ruamel.yaml
+
+# Files that will be ignored
+EXCLUDED_FILES = []
+# A hilariously large line length to ensure we never line-wrap
+MAX_WIDTH = 2000000000
+
+def setup_yaml():
+    # Setup the ruamel.yaml parser
+    yaml = ruamel.yaml.YAML(typ='rt')
+    yaml.preserve_quotes = True
+    # This is what's used in the template, currently ~36 KEPs have drifted
+    yaml.indent(mapping=2, sequence=4, offset=2)
+    yaml.width = MAX_WIDTH
+    return yaml
+
+def edit_kep(yaml, file_name, force_rewrite=False):
+    with open(file_name, "r") as fp:
+        kep = yaml.load(fp)
+
+    rewrite = force_rewrite
+
+    stage = kep.get("stage", "unknown")
+    status = kep.get("status", "unknown")
+    latest_milestone = kep.get("latest-milestone", "unknown")
+    last_updated = kep.get("last-updated", "unknown")
+    milestone = kep.get("milestone", {})
+
+    if status == "implemented":
+        if latest_milestone == "unknown":
+            print(f'status: {status} stage: {stage} last-updated: {last_updated} file: {file_name}')
+            kep["latest-milestone"] = "0.0"
+            rewrite = True
+        if stage == "unknown":
+            if latest_milestone == "unknown":
+                kep["stage"] = "stable"
+            else:
+                kep["stage"] = [s for s,v in milestone.items() if v == latest_milestone][0]
+            rewrite = True
+
+    # Dump KEP to file_name
+    if rewrite:
+        print(f'  writing {file_name}')
+        with open(file_name, "w") as fp:
+            yaml.dump(kep, fp)
+            fp.truncate()
+
+def main(keps_dir, force_rewrite):
+    yaml = setup_yaml()
+    for f in glob.glob(f'{keps_dir}/**/kep.yaml', recursive=True):
+        if path.basename(f) not in EXCLUDED_FILES:
+            try:
+                print(f'processing file: {f}')
+                edit_kep(yaml, f, force_rewrite)
+            except Exception as e:  # pylint: disable=broad-except
+                print(f'ERROR: could not edit {f}: {e}')
+
+if __name__ == '__main__':
+    PARSER = argparse.ArgumentParser(
+        description='Does things to KEPs')
+    PARSER.add_argument(
+        '--keps-dir',
+        default='../keps',
+        help='Path to KEPs directoryProw Job Directory')
+    PARSER.add_argument(
+        '--force',
+        default=False,
+        help='Force rewrite of all KEPs')
+    ARGS = PARSER.parse_args()
+
+    main(ARGS.keps_dir, ARGS.force)
+
diff --git a/keps/prod-readiness/sig-architecture/1143.yaml b/keps/prod-readiness/sig-architecture/1143.yaml
@@ -0,0 +1,3 @@
+kep-number: 1143
+stable:
+  approver: "@wojtek-t"
diff --git a/keps/prod-readiness/sig-auth/2907.yaml b/keps/prod-readiness/sig-auth/2907.yaml
@@ -0,0 +1,3 @@
+kep-number: 2907
+stable:
+  approver: "@johnbelamaric"
diff --git a/keps/prod-readiness/sig-cli/2206.yaml b/keps/prod-readiness/sig-cli/2206.yaml
@@ -0,0 +1,3 @@
+kep-number: 2206
+beta:
+  approver: "@johnbelamaric"
diff --git a/keps/prod-readiness/sig-testing/2539.yaml b/keps/prod-readiness/sig-testing/2539.yaml
@@ -0,0 +1,3 @@
+kep-number: 2539
+beta:
+  approver: "@johnbelamaric"
diff --git a/keps/sig-api-machinery/1152-less-object-serializations/kep.yaml b/keps/sig-api-machinery/1152-less-object-serializations/kep.yaml
@@ -21,3 +21,5 @@ replaces:
   - n/a
 superseded-by:
   - n/a
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml b/keps/sig-api-machinery/1623-standardize-conditions/kep.yaml
@@ -17,3 +17,5 @@ approvers:
   - "@liggitt"
 see-also:
 replaces:
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/2332-pruning-for-custom-resources/kep.yaml b/keps/sig-api-machinery/2332-pruning-for-custom-resources/kep.yaml
@@ -22,3 +22,5 @@ status: implemented
 see-also:
   - "https://github.com/kubernetes/enhancements/pull/1002"
   - "/keps/sig-api-machinery/20180415-crds-to-ga.md"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/2335-vanilla-crd-openapi-subset-structural-schemas/kep.yaml b/keps/sig-api-machinery/2335-vanilla-crd-openapi-subset-structural-schemas/kep.yaml
@@ -22,3 +22,5 @@ see-also:
   - "/keps/sig-api-machinery/20180415-crds-to-ga.md"
   - "https://github.com/kubernetes/enhancements/pull/926"
   - "https://github.com/kubernetes/enhancements/pull/709"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/2337-k8s.io-group-protection/kep.yaml b/keps/sig-api-machinery/2337-k8s.io-group-protection/kep.yaml
@@ -17,3 +17,5 @@ editor: "@deads2k"
 creation-date: 2019-06-12
 last-updated: 2019-07-03
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/492-admission-webhooks/kep.yaml b/keps/sig-api-machinery/492-admission-webhooks/kep.yaml
@@ -15,3 +15,5 @@ last-updated: 2019-02-04
 status: implemented
 see-also:
   - "[Admission Control Webhook Beta Design Doc](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/admission-control-webhooks.md)"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/575-crd-defaulting/kep.yaml b/keps/sig-api-machinery/575-crd-defaulting/kep.yaml
@@ -21,3 +21,5 @@ status: implemented
 see-also:
   - "/keps/sig-api-machinery/20180731-crd-pruning.md"
   - "/keps/sig-api-machinery/20190425-structural-openapi.md"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/576-dry-run/kep.yaml b/keps/sig-api-machinery/576-dry-run/kep.yaml
@@ -15,3 +15,5 @@ editor: apelisse
 creation-date: 2018-06-21
 last-updated: 2020-03-23
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/598-crd-conversion-webhook/kep.yaml b/keps/sig-api-machinery/598-crd-conversion-webhook/kep.yaml
@@ -18,3 +18,5 @@ last-updated: 2019-04-25
 status: implemented
 replaces:
   - "(https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/customresource-conversion-webhook.md)"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-api-machinery/956-watch-bookmark/kep.yaml b/keps/sig-api-machinery/956-watch-bookmark/kep.yaml
@@ -19,3 +19,5 @@ replaces:
   - n/a
 superseded-by:
   - n/a
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-architecture/0000-kep-process/kep.yaml b/keps/sig-architecture/0000-kep-process/kep.yaml
@@ -12,3 +12,5 @@ editor: "@jbeda"
 creation-date: 2017-08-22
 last-updated: 2020-02-18
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-architecture/1194-prod-readiness/kep.yaml b/keps/sig-architecture/1194-prod-readiness/kep.yaml
@@ -18,3 +18,5 @@ approvers:
 creation-date: 2019-07-31
 last-updated: 2020-12-15
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-architecture/1635-prevent-permabeta/kep.yaml b/keps/sig-architecture/1635-prevent-permabeta/kep.yaml
@@ -28,3 +28,4 @@ approvers:
   - "@johnbelamaric"
 see-also:
 replaces:
+stage: stable
diff --git a/keps/sig-architecture/1659-standard-topology-labels/kep.yaml b/keps/sig-architecture/1659-standard-topology-labels/kep.yaml
@@ -22,3 +22,4 @@ stage: stable
 feature-gates: []
 disable-supported: false
 metrics: []
+latest-milestone: '0.0'
diff --git a/keps/sig-auth/1513-certificate-signing-request/kep.yaml b/keps/sig-auth/1513-certificate-signing-request/kep.yaml
@@ -14,3 +14,5 @@ approvers:
 creation-date: 2019-06-07
 last-updated: 2020-09-14
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-auth/1687-hierarchical-namespaces-subproject/kep.yaml b/keps/sig-auth/1687-hierarchical-namespaces-subproject/kep.yaml
@@ -16,3 +16,5 @@ approvers:
 creation-date: 2020-04-14
 last-updated: 2021-01-06
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-auth/266-kubelet-client-certificate-bootstrap-rotation/kep.yaml b/keps/sig-auth/266-kubelet-client-certificate-bootstrap-rotation/kep.yaml
@@ -33,3 +33,4 @@ disable-supported: true
 metrics:
   - kubelet_certificate_manager_client_expiration_seconds
   - kubelet_certificate_manager_client_expiration_renew_errors
+stage: stable
diff --git a/keps/sig-auth/279-limit-node-access/kep.yaml b/keps/sig-auth/279-limit-node-access/kep.yaml
@@ -16,3 +16,5 @@ approvers:
 creation-date: 2017-08-14
 last-updated: 2020-05-01
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-auth/2907-secrets-store-csi-driver/kep.yaml b/keps/sig-auth/2907-secrets-store-csi-driver/kep.yaml
@@ -14,3 +14,4 @@ approvers:
   - "@ritazh"
   - "@mikedanese"
 status: implemented
+stage: stable
diff --git a/keps/sig-auth/789-harden-default-discover-bindings/kep.yaml b/keps/sig-auth/789-harden-default-discover-bindings/kep.yaml
@@ -18,3 +18,5 @@ editor: TBD
 creation-date: 2019-01-28
 last-updated: 2019-01-31
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-autoscaling/117-hpa-metrics-specificity/kep.yaml b/keps/sig-autoscaling/117-hpa-metrics-specificity/kep.yaml
@@ -16,3 +16,5 @@ editor: "@directxman12"
 creation-date: 2018-04-19
 last-updated: 2018-04-19
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-autoscaling/853-configurable-hpa-scale-velocity/kep.yaml b/keps/sig-autoscaling/853-configurable-hpa-scale-velocity/kep.yaml
@@ -16,3 +16,5 @@ creation-date: 2019-03-07
 last-updated: 2020-01-29
 status: implemented
 superseded-by:
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cli/2206-openapi-features-in-kustomize/kep.yaml b/keps/sig-cli/2206-openapi-features-in-kustomize/kep.yaml
@@ -13,7 +13,7 @@ approvers:
   - "@pwittrock"
 creation-date: 2020-12-21
 last-updated: 2020-01-15
-status: implemented
+status: implementable
 
 latest-milestone: "1.22"
 stage: "beta"
diff --git a/keps/sig-cli/2377-Kustomize/kep.yaml b/keps/sig-cli/2377-Kustomize/kep.yaml
@@ -20,3 +20,5 @@ replaces:
   - kinflate # Old name for kustomize
 superseded-by:
   - "/keps/sig-cli/2386-kustomize-subcommand-integration/"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cli/2379-kubectl-plugins/kep.yaml b/keps/sig-cli/2379-kubectl-plugins/kep.yaml
@@ -24,3 +24,5 @@ replaces:
   - "https://github.com/kubernetes/community/pull/481"
 superseded-by:
   - n/a
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cli/2384-kustomize-file-processing-integration/kep.yaml b/keps/sig-cli/2384-kustomize-file-processing-integration/kep.yaml
@@ -24,3 +24,5 @@ see-also:
 replaces:
 superseded-by:
   - n/a
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cli/2386-kustomize-subcommand-integration/kep.yaml b/keps/sig-cli/2386-kustomize-subcommand-integration/kep.yaml
@@ -24,3 +24,5 @@ replaces:
   - "0008-kustomize.md"
 superseded-by:
   - n/a
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cli/491-kubectl-diff/kep.yaml b/keps/sig-cli/491-kubectl-diff/kep.yaml
@@ -17,3 +17,5 @@ status: implemented
 see-also:
   - "/keps/sig-api-machinery/0015-dry-run.md"
   - "/keps/sig-api-machinery/0006-apply.md"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cloud-provider/1179-building-without-in-tree-providers/kep.yaml b/keps/sig-cloud-provider/1179-building-without-in-tree-providers/kep.yaml
@@ -23,3 +23,5 @@ status: implemented
 see-also:
   - "/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md"
   - "/keps/sig-cloud-provider/20180530-cloud-controller-manager.md"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cloud-provider/669-out-of-tree-openstack/kep.yaml b/keps/sig-cloud-provider/669-out-of-tree-openstack/kep.yaml
@@ -15,3 +15,5 @@ editor: TBD
 creation-date: 2019-01-25
 last-updated: 2019-01-25
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cloud-provider/670-out-of-tree-vsphere/kep.yaml b/keps/sig-cloud-provider/670-out-of-tree-vsphere/kep.yaml
@@ -18,3 +18,5 @@ editor: TBD
 creation-date: 2019-01-25
 last-updated: 2020-04-09
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cloud-provider/azure/2328-ccm-instance-metadata/kep.yaml b/keps/sig-cloud-provider/azure/2328-ccm-instance-metadata/kep.yaml
@@ -13,3 +13,5 @@ creation-date: 2019-07-22
 last-updated: 2021-01-26
 status: implemented
 
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-cluster-lifecycle/kubeadm/378-bootstrap-checkpointing/kep.yaml b/keps/sig-cluster-lifecycle/kubeadm/378-bootstrap-checkpointing/kep.yaml
@@ -16,3 +16,5 @@ editor: "@timothysc"
 creation-date: 2017-10-20
 last-updated: 2018-01-23
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-contributor-experience/0000-community-forum/kep.yaml b/keps/sig-contributor-experience/0000-community-forum/kep.yaml
@@ -15,3 +15,5 @@ editor: TBD
 creation-date: 2018-04-03
 last-updated: 2018-04-17
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-contributor-experience/1553-issue-triage/kep.yaml b/keps/sig-contributor-experience/1553-issue-triage/kep.yaml
@@ -20,3 +20,5 @@ approvers:
 creation-date: 2020-02-15
 see-also:
 replaces:
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-contributor-experience/2225-contributor-site/kep.yaml b/keps/sig-contributor-experience/2225-contributor-site/kep.yaml
@@ -15,3 +15,5 @@ editor: TBD
 creation-date: "2018-02-19"
 last-updated: "2021-01-04"
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-instrumentation/1206-metrics-overhaul/kep.yaml b/keps/sig-instrumentation/1206-metrics-overhaul/kep.yaml
@@ -14,3 +14,5 @@ editor: "@DirectXMan12"
 creation-date: 2018-11-06
 last-updated: 2019-03-21
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-network/1024-nodelocal-cache-dns/kep.yaml b/keps/sig-network/1024-nodelocal-cache-dns/kep.yaml
@@ -16,3 +16,5 @@ last-updated: 2020-09-23
 status: implemented
 see-also:
   - "/keps/sig-network/0030-nodelocal-dns-cache.md"
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-network/2447-Make-kube-proxy-service-abstraction-optional/kep.yaml b/keps/sig-network/2447-Make-kube-proxy-service-abstraction-optional/kep.yaml
@@ -15,3 +15,5 @@ status: implemented
 see-also:
 replaces:
 superseded-by:
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-network/2448-Remove-kube-proxy-automatic-clean-up-logic/kep.yaml b/keps/sig-network/2448-Remove-kube-proxy-automatic-clean-up-logic/kep.yaml
@@ -16,3 +16,5 @@ status: implemented
 see-also:
 replaces:
 superseded-by:
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-network/2449-move-externalDNS-out-of-kubernetes-incubator/kep.yaml b/keps/sig-network/2449-move-externalDNS-out-of-kubernetes-incubator/kep.yaml
@@ -7,3 +7,5 @@ approvers:
   - thockin
 owning-sig: sig-network
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-network/2450-Remove-knowledge-of-pod-cluster-CIDR-from-iptables-rules/kep.yaml b/keps/sig-network/2450-Remove-knowledge-of-pod-cluster-CIDR-from-iptables-rules/kep.yaml
@@ -23,3 +23,5 @@ status: implemented
 see-also:
 replaces:
 superseded-by:
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-network/265-ipvs-based-load-balancing/kep.yaml b/keps/sig-network/265-ipvs-based-load-balancing/kep.yaml
@@ -13,3 +13,5 @@ editor: "@thockin"
 creation-date: 2018-03-21
 last-updated: 2019-06-27
 status: implemented
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-network/980-load-balancer-finalizers/kep.yaml b/keps/sig-network/980-load-balancer-finalizers/kep.yaml
@@ -21,3 +21,5 @@ status: implemented
 see-also:
 replaces:
 superseded-by:
+latest-milestone: '0.0'
+stage: stable
diff --git a/keps/sig-node/135-seccomp/kep.yaml b/keps/sig-node/135-seccomp/kep.yaml
@@ -18,3 +18,5 @@ approvers:
 editor: "@saschagrunert"
 creation-date: 2019-07-17
 status: implemented
+latest-milestone: '0.0'
+stage: stable