Chart: Set --enable-metrics to controller.metrics.enabled.

[pmint93]

What this PR does / why we need it:

Metrics is not disabled even with the value metrics.enabled set to false because the chart templates only disable the metrics port.

This PR explicit set the flag --enable-metrics

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Tested on Kubernetes v1.20.9 with helm install test-nginx-ingress . then the flag populated correctly and the metrics endpoint no longer return NGINX prometheus metrics

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @pmint93!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pmint93. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pmint93
Once this PR has been reviewed and has the lgtm label, please assign strongjz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[longwuyuan]

I doubt if that is enough to disable metrics in a cleaner manner.
Would you need to implement the flag in the values.yaml

[pmint93]

@longwuyuan Not sure that I'm understanding you correctly. What do you mean by implementing the flag in values.yaml ?

Currently, if you set value metrics.enabled=false nginx still generate metrics and can be scrape via <POD_IP>:10254/metrics, which is not a desired behaviour.
This PR add --enable-metrics to the flag list, which will be set to deployment/deamonset during helm install.

[pmint93]

/retest

[k8s-ci-robot]

@pmint93: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[github-actions]

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

[Gacko]

/assign

[k8s-triage-robot]

The lifecycle/frozen label can not be applied to PRs.

This bot removes lifecycle/frozen from PRs because:

• Commenting /lifecycle frozen on a PR has not worked since March 2021
• PRs that remain open for >150 days are unlikely to be easily rebased

You can:

• Rebase this PR and attempt to get it merged
• Close this PR with /close

Please send feedback to sig-contributor-experience at kubernetes/community.

/remove-lifecycle frozen

[Gacko]

/retitle Chart: Set --enable-metrics to controller.metrics.enabled.

[Gacko]

/retest

[Gacko]

Could you please rebase your PR and review my suggestion? Thank you! Apart from that we should be ready to merge.

[Gacko]

Suggested change

	- --enable-metrics={{ .Values.controller.metrics.enabled }}
	{{- if not .Values.controller.metrics.enabled }}
	- --enable-metrics={{ .Values.controller.metrics.enabled }}
	{{- end }}

[Gacko]

Closing this as I just implemented this here. Hope this is ok for you! This PR is stale for a while now and I didn't want to wait any longer for this quick fix.

[Gacko]

/close

[k8s-ci-robot]

@Gacko: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.